This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Complete rewrite of the Storage system #46
Open
luxas
wants to merge
149
commits into
weaveworks:master
Choose a base branch
from
luxas:ctrl-runtime-rewrite
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ement controller-runtime-style options, and relevant opt interfaces for interoperability.
…ts MarshalJSON(), by always first encoding "non-pretty", and indenting the JSON a configurable amount of spaces after encoding, but before handing the data to the framewriter.
…me in the serializer. Add a JSONTransformer interface, and make ContentType implement it.
…bjects and lists by their embedded TypeMeta info.
… and the rest of Kubernetes.
…ped and unstructured objects.
…rent patch types. The "object patching" part has been moved to the serializer.
…ype and file-extension lookups
…writer implementation too
…and automatically use it when syncing the unstructured Storage.
…in a good manner, instead of the prior hacks. Add a generic string-string ValueItem, and expose the queries publicly.
… unit tests and comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO to add more description here, but overall: