Skip to content
This repository has been archived by the owner on Mar 20, 2019. It is now read-only.

Commit

Permalink
Prep for use with npm, toolchain updates (#5)
Browse files Browse the repository at this point in the history
* Added prebuild scripts to make sure output is up-to-date when running npm publish
* selected the @wealthsimple/canadian-bank-account package name for npm
* Bumped the version to 1.0.0
* use .npmingore to prune out dev artifacts from people's node_modules folders
* updated to node 8, updated build package versions
* installed a few missing dev dependencies (gulp, coffee-script, jasmine-core)
* commited lockfile
* folded the last PR change into source code (it was made in the build output directly)
* moved build outputs to `dist` to make it clear that's what they are in future.
  • Loading branch information
SethDavenport authored Sep 25, 2017
1 parent 387ab57 commit 76b028d
Show file tree
Hide file tree
Showing 10 changed files with 5,610 additions and 25 deletions.
1 change: 1 addition & 0 deletions .node-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
8.2.1
6 changes: 6 additions & 0 deletions .npmignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
node_modules
test
src
.travis.yml
bower.json
*.coffee
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
language: node_js
node_js:
- "0.10"
- "8.2.1"
2 changes: 1 addition & 1 deletion bower.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "canadian-bank-account",
"description": "Validates transit and account numbers of common Canadian banks",
"main": "canadian-bank-account.js",
"main": "dist/canadian-bank-account.js",
"license": "MIT",
"homepage": "https://github.com/wealthsimple/canadian-bank-account",
"moduleType": [],
Expand Down
2 changes: 1 addition & 1 deletion canadian-bank-account.js → dist/canadian-bank-account.js
100755 → 100644
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ module.exports = {
error: "HSBC Bank of Canada transit number must begin with 10XXX."
},
account: {
regex: [/^[0-9]{9}$/, /^[0-9]{12}$/],
regex: [/^[0-9]{9}$/, /^[0-9]{12}$/],
error: "HSBC Bank of Canada account number must be either 9 or 12 digits long."
}
},
Expand Down
2 changes: 1 addition & 1 deletion gulpfile.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ gulp.task 'browserify', ->
.bundle()
.on('error', handleErrors)
.pipe(source('canadian-bank-account.js'))
.pipe(gulp.dest('.'))
.pipe(gulp.dest('dist'))
.on 'end', ->
gutil.log('Finished', gutil.colors.green("'bundle'"))

Expand Down
2 changes: 1 addition & 1 deletion karma.conf.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ module.exports = (config) ->
'test/vendor/**/*.js',
'test/support/**/*.coffee',
'test/*test.coffee',
'canadian-bank-account.js'
'dist/canadian-bank-account.js'
]


Expand Down
Loading

0 comments on commit 76b028d

Please sign in to comment.