Update k8-configmap.yaml #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I see, actually I missed this configmap values, that is fine let's keep the values in configmap itself, while we were working on the cron job, i manually added the values to secrets. I'll remove them again although the values remain unused from secrets and are redundant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @rar4026 - These values should not be hard-coded. We need these data to be populated in Configmap for the Python script to execute. I've manually updated these values in ConfigMap for now.
Note that these data are in two different places where we have these values: Secrets and Configmap. Maybe we should just keep them in Secrets going forward. If this is the case, you can disregard this PR.
