Skip to content

Commit

Permalink
feat(✨): Add default alias for transition function (#134)
Browse files Browse the repository at this point in the history
  • Loading branch information
wcandillon authored Dec 19, 2019
1 parent 81e4a55 commit c5ff9a6
Show file tree
Hide file tree
Showing 4 changed files with 27 additions and 49 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"@types/react": "*",
"@types/react-native": "^0.60.25",
"eslint": "^6.7.2",
"eslint-config-react-native-wcandillon": "2.3.0",
"eslint-config-react-native-wcandillon": "2.3.1",
"react": "^16.8.6",
"react-native": "^0.61.0",
"react-native-gesture-handler": "~1.5.0",
Expand Down
5 changes: 4 additions & 1 deletion src/Animations.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,9 @@ type Atomic = string | number | boolean;
export const useValues = <V extends Atomic>(
values: V[],
deps: Dependencies
): Animated.Value<V>[] => useMemoOne(() => values.map(v => new Value(v)), deps);
): Animated.Value<V>[] =>
// eslint-disable-next-line react-hooks/exhaustive-deps
useMemoOne(() => values.map(v => new Value(v)), deps);

export const useNamedValues = <V extends Atomic, K extends string>(
values: Record<K, V>,
Expand All @@ -82,4 +84,5 @@ export const useNamedValues = <V extends Atomic, K extends string>(
result[key as K] = new Value(values[key as K]);
});
return result;
// eslint-disable-next-line react-hooks/exhaustive-deps
}, deps);
25 changes: 16 additions & 9 deletions src/Transitions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const {
useCode
} = Animated;

export const withTimingTransition = (
export const withTransition = (
value: Animated.Value<number>,
timingConfig: TimingConfig = {},
gestureState: Animated.Value<State> = new Value(State.UNDETERMINED)
Expand Down Expand Up @@ -89,13 +89,15 @@ export const withSpringTransition = (
]);
};

export const useTimingTransition = (
state: boolean,
config: TimingConfig = {}
) => {
export const withTimingTransition = withTransition;

export const useTransition = (state: boolean, config: TimingConfig = {}) => {
const value = useMemoOne(() => new Value(0), []);
useCode(() => set(value, bin(state)), [state]);
const transition = useMemoOne(() => withTimingTransition(value, config), []);
useCode(() => set(value, bin(state)), [state, value]);
const transition = useMemoOne(() => withTransition(value, config), [
config,
value
]);
return transition;
};

Expand All @@ -104,7 +106,12 @@ export const useSpringTransition = (
config: SpringConfig = {}
) => {
const value = useMemoOne(() => new Value(0), []);
useCode(() => set(value, bin(state)), [state]);
const transition = useMemoOne(() => withSpringTransition(value, config), []);
useCode(() => set(value, bin(state)), [state, value]);
const transition = useMemoOne(() => withSpringTransition(value, config), [
config,
value
]);
return transition;
};

export const useTimingTransition = useTransition;
44 changes: 6 additions & 38 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3049,7 +3049,7 @@ debug@^4.0.0, debug@^4.0.1, debug@^4.1.0, debug@^4.1.1:
dependencies:
ms "^2.1.1"

debuglog@*, debuglog@^1.0.1:
debuglog@^1.0.1:
version "1.0.1"
resolved "https://registry.yarnpkg.com/debuglog/-/debuglog-1.0.1.tgz#aa24ffb9ac3df9a2351837cfb2d279360cd78492"
integrity sha1-qiT/uaw9+aI1GDfPstJ5NgzXhJI=
Expand Down Expand Up @@ -3457,10 +3457,10 @@ eslint-config-prettier@^6.7.0:
dependencies:
get-stdin "^6.0.0"

[email protected].0:
version "2.3.0"
resolved "https://registry.yarnpkg.com/eslint-config-react-native-wcandillon/-/eslint-config-react-native-wcandillon-2.3.0.tgz#e5e4530f8ba34bc52ff5192216222f2ad2ad859d"
integrity sha512-euu2Vgnc8gTVxlQt82xJ5Mfa3/nX565XiTRiVMTRTtjeGmoK7CF0c0kDqRzCu1BASHI2/5H3OtJOGWbxojEP6A==
[email protected].1:
version "2.3.1"
resolved "https://registry.yarnpkg.com/eslint-config-react-native-wcandillon/-/eslint-config-react-native-wcandillon-2.3.1.tgz#beddb1bbe6a075dacf2a7546543ce110231b4acf"
integrity sha512-R1dLnXLMX19wItGIIs098FuZreKK3FfPElfbWSEx8uMPiovoUzs8942Z5QarpeaSCEH5zPT4k6JRZWz1nXkVlg==
dependencies:
"@typescript-eslint/eslint-plugin" "2.10.0"
"@typescript-eslint/parser" "2.10.0"
Expand Down Expand Up @@ -4656,7 +4656,7 @@ import-lazy@^2.1.0:
resolved "https://registry.yarnpkg.com/import-lazy/-/import-lazy-2.1.0.tgz#05698e3d45c88e8d7e9d92cb0584e77f096f3e43"
integrity sha1-BWmOPUXIjo1+nZLLBYTnfwlvPkM=

imurmurhash@*, imurmurhash@^0.1.4:
imurmurhash@^0.1.4:
version "0.1.4"
resolved "https://registry.yarnpkg.com/imurmurhash/-/imurmurhash-0.1.4.tgz#9218b9b2b928a238b13dc4fb6b6d576f231453ea"
integrity sha1-khi5srkoojixPcT7a21XbyMUU+o=
Expand Down Expand Up @@ -5648,11 +5648,6 @@ lockfile@^1.0.4:
dependencies:
signal-exit "^3.0.2"

lodash._baseindexof@*:
version "3.1.0"
resolved "https://registry.yarnpkg.com/lodash._baseindexof/-/lodash._baseindexof-3.1.0.tgz#fe52b53a1c6761e42618d654e4a25789ed61822c"
integrity sha1-/lK1OhxnYeQmGNZU5KJXie1hgiw=

lodash._baseuniq@~4.6.0:
version "4.6.0"
resolved "https://registry.yarnpkg.com/lodash._baseuniq/-/lodash._baseuniq-4.6.0.tgz#0ebb44e456814af7905c6212fa2c9b2d51b841e8"
Expand All @@ -5661,33 +5656,11 @@ lodash._baseuniq@~4.6.0:
lodash._createset "~4.0.0"
lodash._root "~3.0.0"

lodash._bindcallback@*:
version "3.0.1"
resolved "https://registry.yarnpkg.com/lodash._bindcallback/-/lodash._bindcallback-3.0.1.tgz#e531c27644cf8b57a99e17ed95b35c748789392e"
integrity sha1-5THCdkTPi1epnhftlbNcdIeJOS4=

lodash._cacheindexof@*:
version "3.0.2"
resolved "https://registry.yarnpkg.com/lodash._cacheindexof/-/lodash._cacheindexof-3.0.2.tgz#3dc69ac82498d2ee5e3ce56091bafd2adc7bde92"
integrity sha1-PcaayCSY0u5ePOVgkbr9Ktx73pI=

lodash._createcache@*:
version "3.1.2"
resolved "https://registry.yarnpkg.com/lodash._createcache/-/lodash._createcache-3.1.2.tgz#56d6a064017625e79ebca6b8018e17440bdcf093"
integrity sha1-VtagZAF2JeeevKa4AY4XRAvc8JM=
dependencies:
lodash._getnative "^3.0.0"

lodash._createset@~4.0.0:
version "4.0.3"
resolved "https://registry.yarnpkg.com/lodash._createset/-/lodash._createset-4.0.3.tgz#0f4659fbb09d75194fa9e2b88a6644d363c9fe26"
integrity sha1-D0ZZ+7CddRlPqeK4imZE02PJ/iY=

lodash._getnative@*, lodash._getnative@^3.0.0:
version "3.9.1"
resolved "https://registry.yarnpkg.com/lodash._getnative/-/lodash._getnative-3.9.1.tgz#570bc7dede46d61cdcde687d65d3eecbaa3aaff5"
integrity sha1-VwvH3t5G1hzc3mh9ZdPuy6o6r/U=

lodash._root@~3.0.0:
version "3.0.1"
resolved "https://registry.yarnpkg.com/lodash._root/-/lodash._root-3.0.1.tgz#fba1c4524c19ee9a5f8136b4609f017cf4ded692"
Expand Down Expand Up @@ -5728,11 +5701,6 @@ lodash.isstring@^4.0.1:
resolved "https://registry.yarnpkg.com/lodash.isstring/-/lodash.isstring-4.0.1.tgz#d527dfb5456eca7cc9bb95d5daeaf88ba54a5451"
integrity sha1-1SfftUVuynzJu5XV2ur4i6VKVFE=

lodash.restparam@*:
version "3.6.1"
resolved "https://registry.yarnpkg.com/lodash.restparam/-/lodash.restparam-3.6.1.tgz#936a4e309ef330a7645ed4145986c85ae5b20805"
integrity sha1-k2pOMJ7zMKdkXtQUWYbIWuWyCAU=

lodash.set@^4.3.2:
version "4.3.2"
resolved "https://registry.yarnpkg.com/lodash.set/-/lodash.set-4.3.2.tgz#d8757b1da807dde24816b0d6a84bea1a76230b23"
Expand Down

0 comments on commit c5ff9a6

Please sign in to comment.