Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save plugins and reporting repo hashes on workflow variable and updat… #502

Merged
merged 11 commits into from
Oct 31, 2024

Conversation

QU3B1M
Copy link
Member

@QU3B1M QU3B1M commented Oct 29, 2024

Description

This PR applies the new package naming convention, including the last commit of each repository related to wazuh-indexer at the package generation. It also removes the upload field on the build workflows to always upload the packages to S3 as defined here, and adds notice messages to show the S3 bucket URI of the package at the end of the execution.

  • Packages with the new naming conventions image
  • S3 bucket package URI image

Related Issues

Resolves #486

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@QU3B1M QU3B1M self-assigned this Oct 29, 2024
@QU3B1M QU3B1M force-pushed the ci/486-implement-combined-hash-naming branch from 8cf0d8b to 7041320 Compare October 29, 2024 12:24
@QU3B1M QU3B1M force-pushed the ci/486-implement-combined-hash-naming branch from 7041320 to dabd73a Compare October 29, 2024 12:32
@QU3B1M QU3B1M linked an issue Oct 29, 2024 that may be closed by this pull request
@QU3B1M QU3B1M force-pushed the ci/486-implement-combined-hash-naming branch 2 times, most recently from 77ee3a8 to 96e84f5 Compare October 29, 2024 15:23
@QU3B1M QU3B1M force-pushed the ci/486-implement-combined-hash-naming branch from 96e84f5 to d3f33de Compare October 29, 2024 15:25
Update build GHA to send hashes by parameters to the baptizer script
@QU3B1M QU3B1M force-pushed the ci/486-implement-combined-hash-naming branch from 535bb89 to c76d778 Compare October 29, 2024 19:58
@QU3B1M QU3B1M marked this pull request as ready for review October 29, 2024 20:29
@QU3B1M QU3B1M requested a review from a team as a code owner October 29, 2024 20:29
Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QU3B1M QU3B1M force-pushed the ci/486-implement-combined-hash-naming branch from 0146570 to 77665a1 Compare October 31, 2024 00:11
@QU3B1M
Copy link
Member Author

QU3B1M commented Oct 31, 2024

Using the upload option as true the build on demand uploads correctly the packages to S3 and shares its URL on the anotation section.

image

Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexRuiz7 AlexRuiz7 merged commit 7786338 into master Oct 31, 2024
13 checks passed
@AlexRuiz7 AlexRuiz7 deleted the ci/486-implement-combined-hash-naming branch October 31, 2024 15:55
AlexRuiz7 pushed a commit that referenced this pull request Nov 8, 2024
#502)

* Save plugins and reporting repo hashes on workflow variable and update baptizer script to use it on package naming

* Update GHA workflow to save hash on global variable

* Update GHA to use env

* Update GHA workflow to save the hash on a output variable

* Fix environment variable usage

* Update baptizer to receive the repositories hashes by parameter

Update build GHA to send hashes by parameters to the baptizer script

* Update build-scripts README.md with new baptizer parameters

* Update build GHA workflow to show the URL of the uploaded package at the job view

* Update GHA build workflow to always upload package to the S3 bucket

Remove 'upload' check on workflow input

* Restore upload input and corresponding validations

* Remove commented lines
AlexRuiz7 pushed a commit that referenced this pull request Nov 18, 2024
#502)

* Save plugins and reporting repo hashes on workflow variable and update baptizer script to use it on package naming

* Update GHA workflow to save hash on global variable

* Update GHA to use env

* Update GHA workflow to save the hash on a output variable

* Fix environment variable usage

* Update baptizer to receive the repositories hashes by parameter

Update build GHA to send hashes by parameters to the baptizer script

* Update build-scripts README.md with new baptizer parameters

* Update build GHA workflow to show the URL of the uploaded package at the job view

* Update GHA build workflow to always upload package to the S3 bucket

Remove 'upload' check on workflow input

* Restore upload input and corresponding validations

* Remove commented lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid ambiguous wazuh-indexer package naming
2 participants