Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Http Client Logic #93

Merged
merged 23 commits into from
Oct 14, 2024
Merged

Conversation

f-galland
Copy link
Member

Description

This PR adds Http client functionality to the command manager plugin, meant to query the Wazuh Server's command API.

Issues Resolved

Resolves #89

@f-galland f-galland self-assigned this Oct 4, 2024
@f-galland
Copy link
Member Author

I've attempted to migrate towards HttpClient but I've found that it depends on SLF4J which seems not to be compatible with org.apache.logging.log4j.Logger (which is the logging library we've been using so far).

We might have to move all the plugins to slf4j for consistency's sake.

@f-galland
Copy link
Member Author

f-galland commented Oct 8, 2024

Actually, just adding slf4j to the build.gradle following the example in HttpClient's pom gets rid of the issue.

Now I get a new error (which seems more frequent in google results):

[2024-10-08T08:36:25,160][WARN ][stderr                   ] [integTest-0] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
[2024-10-08T08:36:25,160][WARN ][stderr                   ] [integTest-0] SLF4J: Defaulting to no-operation (NOP) logger implementation
[2024-10-08T08:36:25,161][WARN ][stderr                   ] [integTest-0] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

@f-galland f-galland marked this pull request as ready for review October 9, 2024 20:02
@f-galland f-galland requested a review from a team as a code owner October 9, 2024 20:02
@AlexRuiz7 AlexRuiz7 merged commit 1a5fe23 into master Oct 14, 2024
1 check passed
@AlexRuiz7 AlexRuiz7 deleted the 89-implement-http-client-logic branch October 14, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement HTTP client logic
2 participants