Implement spotless gradle pre-commit hook #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess on indexer plugins
QU3B1M
force-pushed
the
ci/104-spotless-gradle-precommit
branch
from
4ddd9ef to
b781a96
Compare
- Order build.gradle blocks - Add spotless plugin to build.gradle - Update formatting.gradle for both plugins
AlexRuiz7
reviewed
Oct 16, 2024
AlexRuiz7
reviewed
Oct 16, 2024
AlexRuiz7
reviewed
Oct 16, 2024
- Add license-header.txt file with the expected content of the headers - Update formatting.gradle on both plugins to validate the license header - Rename buildSrc directory to formatter
QU3B1M
force-pushed
the
ci/104-spotless-gradle-precommit
branch
from
574156a to
1f439d1
Compare
…subprojects - Move spotless-related configuration to main project directory - Add pre-commit hook script to run spotlessCheck - Add block on build.gradle to automatically apply pre-commit script into local .git dir - Remove duplicated spotless-related code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of the spotless tool to lint and format the code and a pre-commit hook to execute a
spotlessCheckautomatically.Important
The pre-commit hook is applied to our local
.gitdir on the first run of the./gradlew buildcommand.This PR also includes the generation of a root Gradle project to handle generic processes for the plugins avoiding code duplication, for now it only handles the spotless actions.
The formatting options included in this spotless implementations are:
All these format options can be applied by running
./gradlew spotlessApplyfrom the project's root directory.Issues Resolved