Merge pull request #3 from wayfair/fallback_uuid

include uuid as id in fallback html
wayfair · Jan 20, 2017 · f7a8684 · f7a8684
2 parents 99bb725 + 8dca14f
commit f7a8684
Show file tree

Hide file tree

Showing 3 changed files with 137 additions and 4 deletions.
diff --git a/composer.json b/composer.json
@@ -4,7 +4,8 @@
     "type": "library",
     "require": {
         "php": ">=5.6.0",
-        "guzzlehttp/guzzle": "^6.2"
+        "guzzlehttp/guzzle": "^6.2",
+        "ramsey/uuid": "^3.5"
     },
     "require-dev": {
         "phpunit/phpunit": "^5.7"

diff --git a/composer.lock b/composer.lock
diff --git a/src/Renderer.php b/src/Renderer.php
@@ -214,10 +214,12 @@ protected function fallback($topLevelError, $jobs)
      */
     protected function getFallbackHTML($moduleName, $data)
     {
+        $uuid = \Ramsey\Uuid\Uuid::uuid4();
         return sprintf(
-            '<div data-hypernova-key="%1$s"></div>
-    <script type="application/json" data-hypernova-key="%1$s"><!--%2$s--></script>',
+            '<div data-hypernova-key="%1$s" data-hypernova-id="%2$s"></div>
+    <script type="application/json" data-hypernova-key="%1$s" data-hypernova-id="%2$s"><!--%3$s--></script>',
             $moduleName,
+            $uuid,
             json_encode($data)
         );
     }