Skip to content
This repository has been archived by the owner on Mar 1, 2019. It is now read-only.

Adds isNode check. #277

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adds isNode check. #277

wants to merge 3 commits into from

Conversation

artemruts
Copy link
Contributor

Overview

Adds isNode check for nodes A and B when checking if A.contains(B).
This should prevent IE10 errors for hover events, for more details please refer to pt:7458101.

Details

Function was tested on:

Windows 7

  • IE 8
  • IE 9
  • IE 10
  • IE 11
  • Safari 4
  • Safari 5.1
  • Firefox 42
  • Firefox 49

OSX Sierra

  • Safari 10
  • Opera 32
  • Opera 40
  • Chrome 47
  • Chrome 56

iOS

  • iPhone 4, iOS 4, Safari
  • iPhone 6, iOS 8, Safari
  • iPhone 7, iOS 10, Safari

Android

  • Galaxy S2, Android 2.3
  • Nexus 6p, Android 7

@codecov-io
Copy link

codecov-io commented Oct 29, 2016

Current coverage is 84.85% (diff: 100%)

Merging #277 into master will increase coverage by 0.08%

@@             master       #277   diff @@
==========================================
  Files           119        119          
  Lines          6511       6519     +8   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           5520       5532    +12   
+ Misses          991        987     -4   
  Partials          0          0          

Powered by Codecov. Last update 0bce1e3...f82bdb7

@danieluhl
Copy link
Contributor

Looks good to me

@artemruts
Copy link
Contributor Author

Hey @MattDeeg, does this make sense to you? If yes, could you approve please?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants