Split linking_tags.wast into two files #255
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits
linking_tags.wast
into two files.This is a preparation step needed to land fast effect forwarding due to the following:
linking_tags.wast
currently has twoassert_suspension
directives. In the current implementation, we are always on the main stack when we detect that a tag is unhandled and trap from there. However, in the presence of fast effect forwarding, we detect the lack of an appropriate handler at thesuspend
site and trap there (i.e., possibly while still running on a continuation stack).As a result, the
assert_suspension
directives inlinking_tags.wast
trigger the problem described in #253 as soon as fast fowarding lands. As a workaround, this PR splits the file into two, where theassert_suspension
is the very last step in each test (i.e., we avoid further execution inside theStore
where we trapped while inside a continuation). The combined contents of both files is identical to the originallinking_tags.wast
, but the modulebar
is moved to the end of the second file.