Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split linking_tags.wast into two files #255

Merged

Conversation

frank-emrich
Copy link

This PR splits linking_tags.wast into two files.

This is a preparation step needed to land fast effect forwarding due to the following:
linking_tags.wast currently has two assert_suspension directives. In the current implementation, we are always on the main stack when we detect that a tag is unhandled and trap from there. However, in the presence of fast effect forwarding, we detect the lack of an appropriate handler at the suspend site and trap there (i.e., possibly while still running on a continuation stack).

As a result, the assert_suspension directives in linking_tags.wast trigger the problem described in #253 as soon as fast fowarding lands. As a workaround, this PR splits the file into two, where the assert_suspension is the very last step in each test (i.e., we avoid further execution inside the Store where we trapped while inside a continuation). The combined contents of both files is identical to the original linking_tags.wast, but the module bar is moved to the end of the second file.

Copy link
Member

@dhil dhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@frank-emrich frank-emrich merged commit d5c1957 into wasmfx:main Nov 18, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants