[WAR-489] DKG test mockup using Fp and sample tracing #21

merolish · 2024-08-19T16:33:22Z

DKG example in /examples
At the moment, some Fp debug tracing

linear · 2024-08-19T16:33:25Z

WAR-489 DKG tests

0xAlcibiades · 2024-08-19T17:34:43Z

Clippy, fmt, and test fix ser!

…into mike/dkg-tests

0xAlcibiades

We should move this to /examples and make it compile, as discussed, resolve lint issues and make it satisfy CI.

…into mike/dkg-tests

trbritt

left some light comments on the dkg stuff

Cargo.toml

trbritt · 2024-08-20T20:51:59Z

Cargo.toml

+tracing = "0.1.40"
+confy = "0.6.1"
+rand = "0.9.0-alpha.2"


why is rand explicitly imported? We should be using crypto_bigint::rand_core for all things rng

That's a leftover from when I was generating regular ints, will remove.

examples/dkg.rs

trbritt · 2024-08-20T20:53:44Z

examples/dkg.rs

+    while values.len() < count {
+        let value =
+            <Fp as FieldExtensionTrait<1, 1>>::rand(&mut OsRng) % Fp::from(max) + Fp::from(min);
+        values.insert(value.value());


Was there still the issue of adding the Eq trait to Fp?

Yes...here I'm using U256s. Let me try that out.

trbritt · 2024-08-20T20:53:58Z

examples/dkg.rs

+    values.into_iter().map(Fp::new).collect()
+}
+
+#[allow(dead_code)]


how come this is dead? is it just clippy being silly?

Clippy will complain if there is any unused field. I can remove/comment out for the purpose of this test. In a distributed system they'd end up being used, hence having them.

Glad to do whatever would be most illustrative.

it's fine to leave it in, but it may be worth adding a comment stating this so it doesn't seem like we're just having code here for its own sake but for our future compatibility with the code we will eventually write for infra

examples/dkg.rs

0xAlcibiades · 2024-08-20T22:57:29Z

src/fields/fp.rs

@@ -374,33 +374,45 @@ macro_rules! define_finite_prime_field {
                if other.is_zero() {
                    return Self::from(0u64);
                }
-                let (mut _q, mut _r) = self
+                let (mut _q, mut _r) = dbg!(self


we should be using the tracing::debug! macro here. We should not be wrapping the production code in the debug macro itself imo.

i.e. we should print debug statements of the values via tracing::debug, but such that they don't end up in the production build.

Got it. My understanding was that dbg! worked in the same way, will opt for using tracing by default everywhere.

0xAlcibiades

Meant to request changes.

…into mike/dkg-tests

trbritt

Only one minor thing to change but overall it seems to be nice; good tracing in the mission critical stuff, and done in a way that doesn't seem to me to introduce branching => SCAs.

DKG also looks very nice too. I think that what's going to happen eventually when I make the thresholding signatures is that I'll make a general polynomial struct that the both the DKG and threshold BLS can use, so this will likely change a little but is an excellent self-contained cut. Great stuff!

trbritt · 2024-08-21T16:52:45Z

src/fields/fp.rs

@@ -133,7 +133,8 @@ macro_rules! define_finite_prime_field {

        //special struct for const-time arithmetic on montgomery form integers mod p
        type $output = crypto_bigint::modular::ConstMontyForm<$mod_struct, { $mod_struct::LIMBS }>;
-        #[derive(Clone, Debug, Copy)] //to be used in const contexts
+        #[derive(Clone, Copy)] //to be used in const contexts
+        #[derive(Eq)]


consildate into one line please

Ah, yes, I separated because of the const context comment. I can clarify that to just refer to clone/copy.

trbritt · 2024-08-21T17:34:38Z

But please run fmt and clippy, forgot to mention!

trbritt

small typos to fix; but otherwise lgtm! great work

trbritt · 2024-08-21T19:59:49Z

src/pairing.rs

@@ -130,6 +131,7 @@ impl MillerLoopResult {
            let mut z5 = f.0[1].0[2];
            // Line 9
            let (t0, t1) = fp4_square(z0, z1);
+            tracing::debug!(?t0, ?t1, "MillerLoopResult::cyclotonic_squared");


typos here and in line 144, should be "cyclotomic" with an "m", not "cyclotonic"

trbritt · 2024-08-21T19:59:58Z

src/pairing.rs

@@ -139,6 +141,7 @@ impl MillerLoopResult {

            let (mut t0, t1) = fp4_square(z2, z3);
            let (t2, t3) = fp4_square(z4, z5);
+            tracing::debug!(?t0, ?t1, ?t2, ?t3, "MillerLoopResult::cyclotonic_squared");


see above comment

…into mike/dkg-tests

[WAR-489] DKG test mockup using Fp

6f19578

Example commitment fail/kick

059c0e0

merolish requested review from trbritt and 0xAlcibiades August 19, 2024 16:54

0xAlcibiades marked this pull request as ready for review August 19, 2024 17:34

merolish added 2 commits August 19, 2024 13:51

Merge branch 'main' of https://github.com/warlock-labs/alt-bn128-bls …

55a0971

…into mike/dkg-tests

Merge branch 'main' of https://github.com/warlock-labs/alt-bn128-bls …

14e6e45

…into mike/dkg-tests

0xAlcibiades requested changes Aug 20, 2024

View reviewed changes

merolish added 7 commits August 19, 2024 21:37

Move dkg to examples

54dbfcb

Merge branch 'main' of https://github.com/warlock-labs/alt-bn128-bls …

c0e15c0

…into mike/dkg-tests

Fix config

42e7fc3

cleanup

dd25ede

fmt

5391601

clippy

94d1d9f

Some debug tracing for intermediate operations

acd1593

trbritt reviewed Aug 20, 2024

View reviewed changes

merolish added 2 commits August 20, 2024 16:11

review fixes

003c8da

Add Eq/Hash for Fp to support use as hash key

4d2f531

0xAlcibiades approved these changes Aug 20, 2024

View reviewed changes

0xAlcibiades requested changes Aug 20, 2024

View reviewed changes

merolish added 2 commits August 21, 2024 08:27

Merge branch 'main' of https://github.com/warlock-labs/alt-bn128-bls …

25d2c8f

…into mike/dkg-tests

More tracing

de8b2b2

merolish changed the title ~~[WAR-489] DKG test mockup using Fp~~ [WAR-489] DKG test mockup using Fp and sample tracing Aug 21, 2024

trbritt approved these changes Aug 21, 2024

View reviewed changes

fix, yet more tracing

6a87548

trbritt reviewed Aug 21, 2024

View reviewed changes

typo fix

82426c6

Remove unused fields from example

d303b0b

0xAlcibiades approved these changes Aug 21, 2024

View reviewed changes

Merge branch 'main' of https://github.com/warlock-labs/alt-bn128-bls …

3375169

…into mike/dkg-tests

merolish merged commit b36d074 into main Aug 21, 2024
15 checks passed

merolish deleted the mike/dkg-tests branch August 21, 2024 23:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WAR-489] DKG test mockup using Fp and sample tracing #21

[WAR-489] DKG test mockup using Fp and sample tracing #21

merolish commented Aug 19, 2024 •

edited

Loading

linear bot commented Aug 19, 2024

0xAlcibiades commented Aug 19, 2024

0xAlcibiades left a comment

trbritt left a comment

trbritt Aug 20, 2024

merolish Aug 20, 2024

trbritt Aug 20, 2024

merolish Aug 20, 2024

trbritt Aug 20, 2024

merolish Aug 20, 2024

merolish Aug 20, 2024

trbritt Aug 20, 2024

0xAlcibiades Aug 20, 2024

0xAlcibiades Aug 20, 2024

merolish Aug 20, 2024

0xAlcibiades left a comment

trbritt left a comment

trbritt Aug 21, 2024

merolish Aug 21, 2024

trbritt commented Aug 21, 2024

trbritt left a comment

trbritt Aug 21, 2024

merolish Aug 21, 2024

trbritt Aug 21, 2024

[WAR-489] DKG test mockup using Fp and sample tracing #21

[WAR-489] DKG test mockup using Fp and sample tracing #21

Conversation

merolish commented Aug 19, 2024 • edited Loading

linear bot commented Aug 19, 2024

0xAlcibiades commented Aug 19, 2024

0xAlcibiades left a comment

Choose a reason for hiding this comment

trbritt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xAlcibiades left a comment

Choose a reason for hiding this comment

trbritt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

trbritt commented Aug 21, 2024

trbritt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

merolish commented Aug 19, 2024 •

edited

Loading