General fixes - section hide inconsistencies #218
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes performed:
defun
workspaces
andemojify
magit-section-root
to the root node in the review buffermagit-section-toggle
onFiles changed
sectionmagit-section
but couldn't find why this happens as all of this code is delegated tomagit-diff-wash-diff
function. Anyway, I added an extra space between each file name and I was not able to reproduce the error anymore. Aesthetically not pleasant, but I'm more concerned with keeping the functionality predictable and stable now.