Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General fixes - section hide inconsistencies #218

Merged
merged 9 commits into from
Jun 29, 2022

Conversation

wandersoncferreira
Copy link
Owner

@wandersoncferreira wandersoncferreira commented Jun 29, 2022

Fixes performed:

  • Conversation section without any default value
  • Refactor function to include binary files to its own defun
  • Break the commit msg to include a single line in the PR page and show the whole body once the commit is toggled
  • Improve docs for Doom Emacs users on workspaces and emojify
  • Create a proper magit-section-root to the root node in the review buffer
  • Fix inconsistencies with magit-section-toggle on Files changed section
    • The solution here is not good yet, I've managed to find some issues with the region used by magit-section but couldn't find why this happens as all of this code is delegated to magit-diff-wash-diff function. Anyway, I added an extra space between each file name and I was not able to reproduce the error anymore. Aesthetically not pleasant, but I'm more concerned with keeping the functionality predictable and stable now.
  • Fix comments mis-positioning once send to remote
  • Fix CI
  • Check if would be possible to improve Emacs Evil experience in the buffer

@wandersoncferreira wandersoncferreira merged commit 95b36ec into master Jun 29, 2022
@wandersoncferreira wandersoncferreira deleted the fix-major-issues branch June 29, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant