fix(weave): optimize finding next tick up or down #3231
Conversation
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=147e5b610b5e7647a2300a61ce65496d23143dea |
| diff < minDiff && | ||
| ((increasing && tick >= val) || (!increasing && tick <= val)) | ||
| ) { | ||
| closest = tick; |
There was a problem hiding this comment.
could we have something to break out early if tick is equal to val?
There was a problem hiding this comment.
Yeah, lets not go searching through half the list if the slider increments to a valid step, heh. Good call.
| const end = Date.now(); | ||
| const duration = end - start; | ||
| expect(actual).toBe(500002); | ||
| expect(duration).toBeLessThanOrEqual(1); |
There was a problem hiding this comment.
these tests are awesome! could you add one for testing the bounds as well? like one where the val is less than the smallest tick and also one where the val is larger than the largest tick?
There was a problem hiding this comment.
Oh I like it, sure. That logic lives in the update() function that calls getClosestTick() when it has a list of ticks. I might suck that logic into this function instead, and leave update() as a, "get the right value and synchronize the inputs fields."
Description
Fixes
getNearestTick()inSliderInput.tsxby including the existing value of the slider to to determine whether to look above or below the previous value.Optimized function for better performance over large lists.
Included a new test file for basic unit tests of the function.
Testing
Added new unit tests to verify basic functionality.
Created a project with varying steps to ensure slider increments appropriately.