Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(weave): add spiral icon #3226

Merged
merged 6 commits into from
Dec 12, 2024
Merged

Conversation

mbarrramsey
Copy link
Contributor

@mbarrramsey mbarrramsey commented Dec 12, 2024

Description

Adding spiral icon for use on fullscreen panel 404 page (https://wandb.atlassian.net/browse/WB-22294), see figma

Testing

How was this PR tested?

@mbarrramsey mbarrramsey marked this pull request as ready for review December 12, 2024 23:08
@mbarrramsey mbarrramsey requested review from a team as code owners December 12, 2024 23:08
Copy link
Collaborator

@jamie-rasmussen jamie-rasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This icon should probably have been created with the placeholder color that the addicon script will replace with currentColor

@mbarrramsey
Copy link
Contributor Author

@jamie-rasmussen redid with fill="currentColor", thanks!

@mbarrramsey mbarrramsey merged commit 4c73aa3 into master Dec 12, 2024
121 checks passed
@mbarrramsey mbarrramsey deleted the mbarrramsey/add_spiral_icon branch December 12, 2024 23:48
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants