chore(weave): refactor objects query into a simple query builder #3223
+619
−214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=efa2e7bba40e293f7bf3cf04602d76782857d07b |
gtarpenning
changed the title
This stack of pull requests is managed by Graphite. Learn more about stacking. |
tssweeney
reviewed
Dec 13, 2024
tssweeney
reviewed
Dec 13, 2024
|
|
||
|
|
||
| def test_make_object_id_conditions_part(): | ||
| assert _make_object_id_conditions_part(None) == "" |
There was a problem hiding this comment.
seems like a weird function to me - it assumes that it always comes after a non-empty where clause?
There was a problem hiding this comment.
Its meant to be an internal fn but i see your point. i'll rename and add a bit of logic here
tssweeney
reviewed
Dec 13, 2024
tssweeney
reviewed
Dec 13, 2024
tssweeney
reviewed
Dec 13, 2024
tssweeney
reviewed
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Straight refactor for readability. Use a query builder to handle adding conditions to the objects query. Considerably less extensive or flexible as the other query builders, but the objects query is also much more complex. Not sure we need as much flexibility here, this pr should be a balance between risky and merely surface level.
Testing
Existing code coverage + unit tests