Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): Playground: make editor component resizeable #3217

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

m-rgba
Copy link
Contributor

@m-rgba m-rgba commented Dec 12, 2024

Issue:

Editor is currently setting a max-height when auto-expanding.
If we unlock max-height the editing view could be too long, pushing away the Cancel and Save controls.

Solution:

  • Added a resizeable condition to the editor input component (disable if autogrow is enabled).
  • Gave it a larger starting height.
  • Disabled setIsShowingMore for max-height on edit so the user can expand the input.

Note:

Could we keep passing that generated height of the message content into the editor component?

  • I think the perfect solution would be to un-cap the editor and have it auto-grow - we'd need some form of sticky action bar for the editor though to solve the issue addressed above.
  • This PR will help fix the immediate usability issue though.

Before

CleanShot 2024-12-12 at 11 52 45@2x

After

CleanShot 2024-12-12 at 11 51 59@2x

@m-rgba m-rgba changed the title chore(ui): Make editor component resizeable chore(ui): Playground: make editor component resizeable Dec 12, 2024
@m-rgba
Copy link
Contributor Author

m-rgba commented Dec 12, 2024

@m-rgba m-rgba marked this pull request as ready for review December 12, 2024 16:54
@m-rgba m-rgba requested review from a team as code owners December 12, 2024 16:54
@m-rgba m-rgba merged commit 99d07b4 into master Dec 12, 2024
121 checks passed
@m-rgba m-rgba deleted the playground-edit-area branch December 12, 2024 17:58
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants