Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Add error details button #3215

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

jamie-rasmussen
Copy link
Collaborator

@jamie-rasmussen jamie-rasmussen commented Dec 12, 2024

Description

Internal Slack: https://weightsandbiases.slack.com/archives/C03BSTEBD7F/p1733949860779329

Adds a "Copy error details" button to our large error panel. This copies a bunch of useful information to the clipboard in JSON format. Note the TabUseCall change here is just for testing and will be removed before merge.

Screenshot 2024-12-12 at 1 53 17 AM

Example error details from FeatureBee:

{
  "uuid": "0193b9da-ee39-752f-a112-76066dfa2d03",
  "url": "https://beta.wandb.ai/jamie-rasmussen/2024-12-12_intro-example/weave/traces?cols=%7B%22attributes.weave.client_version%22%3Afalse%2C%22attributes.weave.os_name%22%3Afalse%2C%22attributes.weave.os_release%22%3Afalse%2C%22attributes.weave.os_version%22%3Afalse%2C%22attributes.weave.source%22%3Afalse%2C%22attributes.weave.sys_version%22%3Afalse%7D&peekPath=%2Fjamie-rasmussen%2F2024-12-12_intro-example%2Fcalls%2F0193b9c4-40ee-77d0-b6e3-b2ec4b1ecfa1%3Ftracetree%3D0%26feedbackExpand%3D0",
  "error": {
    "message": "Not implemented",
    "stack": [
      "Error: Not implemented",
      "    at vke (https://cdn.wandb.ai/beta/77f5a8a29/assets/index-yzTDyFzw.js:924:702)",
      "    at Nh (https://cdn.wandb.ai/beta/77f5a8a29/assets/index-C4_309S1.js:100:18945)",
      "    at Vk (https://cdn.wandb.ai/beta/77f5a8a29/assets/index-C4_309S1.js:102:48625)",
      "    at Uk (https://cdn.wandb.ai/beta/77f5a8a29/assets/index-C4_309S1.js:102:43875)",
      "    at Tk (https://cdn.wandb.ai/beta/77f5a8a29/assets/index-C4_309S1.js:102:43798)",
      "    at Ik (https://cdn.wandb.ai/beta/77f5a8a29/assets/index-C4_309S1.js:102:43638)",
      "    at Ek (https://cdn.wandb.ai/beta/77f5a8a29/assets/index-C4_309S1.js:102:40439)",
      "    at jg (https://cdn.wandb.ai/beta/77f5a8a29/assets/index-C4_309S1.js:100:3536)",
      "    at Qk (https://cdn.wandb.ai/beta/77f5a8a29/assets/index-C4_309S1.js:102:40798)",
      "    at Jb (https://cdn.wandb.ai/beta/77f5a8a29/assets/index-C4_309S1.js:99:9570)",
      "    at hd (https://cdn.wandb.ai/beta/77f5a8a29/assets/index-C4_309S1.js:99:35530)",
      "    at fd (https://cdn.wandb.ai/beta/77f5a8a29/assets/index-C4_309S1.js:99:18619)",
      "    at ed (https://cdn.wandb.ai/beta/77f5a8a29/assets/index-C4_309S1.js:99:18361)",
      "    at HTMLDivElement.rt (https://cdn.wandb.ai/beta/77f5a8a29/assets/index-C4_309S1.js:45:2042)"
    ]
  },
  "timestamp_err": {
    "iso": "2024-12-12T07:52:33.082Z",
    "long": "Thursday, December 12, 2024 at 7:52:33 AM Coordinated Universal Time",
    "user": "Thursday, December 12, 2024 at 1:52:33 AM Central Standard Time"
  },
  "timestamp_copied": {
    "iso": "2024-12-12T07:54:58.814Z",
    "long": "Thursday, December 12, 2024 at 7:54:58 AM Coordinated Universal Time",
    "user": "Thursday, December 12, 2024 at 1:54:58 AM Central Standard Time"
  },
  "user": {
    "id": "VXNlcjo0NTI1NDQ=",
    "username": "jamie-rasmussen"
  },
  "cookies": {
    "betaVersion": "77f5a8a29",
  },
  "browser": {
    "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36",
    "language": "en-IE",
    "screenSize": {
      "width": 1728,
      "height": 1117
    },
    "viewportSize": {
      "width": 1589,
      "height": 799
    }
  }
}

Testing

How was this PR tested? See FeatureBee

@circle-job-mirror
Copy link

@jamie-rasmussen jamie-rasmussen force-pushed the jamie/error-details-button branch 2 times, most recently from e4df06f to 6880b69 Compare December 12, 2024 07:40
@jamie-rasmussen jamie-rasmussen marked this pull request as ready for review December 12, 2024 07:58
@jamie-rasmussen jamie-rasmussen requested review from a team as code owners December 12, 2024 07:58
datadogRum.addAction(
'weave_panel_error_boundary',
weaveErrorToDDPayload(error)
weaveErrorToDDPayload(error, undefined, uuid)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I need to get this into prod before I can figure out if passing the UUID to datadog and Sentry is working.

@jamie-rasmussen jamie-rasmussen force-pushed the jamie/error-details-button branch from 1982199 to 5c17777 Compare December 12, 2024 15:31
@jamie-rasmussen jamie-rasmussen merged commit 968a99d into master Dec 12, 2024
121 checks passed
@jamie-rasmussen jamie-rasmussen deleted the jamie/error-details-button branch December 12, 2024 16:02
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants