Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): update UUID dependency to v11 (latest) #3208

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

jamie-rasmussen
Copy link
Collaborator

@jamie-rasmussen jamie-rasmussen commented Dec 11, 2024

Description

We're not using this library in many places, but it would be nice to use it more e.g. for generating request IDs.

Upgrading allows us to remove @types/uuid
https://github.com/uuidjs/uuid/blob/HEAD/CHANGELOG.md

We also have our own implementation of v4 in the codebase we could likely get rid of.
https://github.com/wandb/weave/blob/master/weave-js/src/core/util/id.ts#L8

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/@types/[email protected]

View full report↗︎

@circle-job-mirror
Copy link

@jamie-rasmussen jamie-rasmussen marked this pull request as ready for review December 11, 2024 22:13
@jamie-rasmussen jamie-rasmussen requested a review from a team as a code owner December 11, 2024 22:13
@jamie-rasmussen jamie-rasmussen merged commit 16e47c3 into master Dec 11, 2024
121 checks passed
@jamie-rasmussen jamie-rasmussen deleted the jamie/uuid11 branch December 11, 2024 22:19
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants