-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ui): replace WBIcon from @wandb/ui with local version #3202
base: master
Are you sure you want to change the base?
refactor(ui): replace WBIcon from @wandb/ui with local version #3202
Conversation
Co-Authored-By: [email protected] <[email protected]>
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is a typosquat?Package name is similar to other popular packages and may not be the package you want. Use care when consuming similarly named packages and ensure that you did not intend to consume a different package. Malicious packages often publish using similar names as existing popular packages. What is a CVE?Contains a high severity Common Vulnerability and Exposure (CVE). Remove or replace dependencies that include known high severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies. What is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. Why is native code a concern?Contains native code (e.g., compiled binaries or shared libraries). Including native code can obscure malicious behavior. Verify that the inclusion of native code is expected and necessary for this package's functionality. If it is unnecessary or unexpected, consider using alternative packages without native code to mitigate potential risks. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
@@ -0,0 +1,95 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this file? why are we making wandb-weave.tgz? Don't do that
recordEvent('REMOVE_COLUMN_SORT'); | ||
updateTableState(Table.disableSortByCol(tableState, colId)); | ||
await updateTableState(Table.disableSortByCol(tableState, colId)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep unrelated changes to a minimum
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
Add "(aside)" to your comment to have me ignore it. |
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=a1b856b0f0fd646f94fdaa1e55b2f484407d6341 |
This PR replaces the WBIcon component from @wandb/ui with a local version in weave-js/src/common/components/elements/. The changes include:
All local checks (yarn install, lint, build) are passing.
Link to Devin run: https://app.devin.ai/sessions/ec8dd469d1e84218b6b04afd7f5ba96e