-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(weave_ts): remove babel dependencies #3193
base: master
Are you sure you want to change the base?
Conversation
Co-Authored-By: [email protected] <[email protected]>
- Remove babel dependencies as they're no longer needed - Remove babel.config.cjs - Update vite.config.ts comments - JSX transpilation handled by esbuild in both dev and prod - Verified Fast Refresh functionality Co-Authored-By: [email protected] <[email protected]>
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/[email protected] |
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
Add "(aside)" to your comment to have me ignore it. |
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=e6dc7f49ce185226538c10b177ad0f7f04cd537e |
weave-js/src/contextProviders.tsx
Outdated
@@ -55,7 +55,7 @@ export const ComputeGraphContextProviderFromClient: React.FC<{client: Client}> = | |||
data-test-num-shadow-server-requests-counter={ | |||
GlobalCGEventTracker.shadowServerRequests | |||
} | |||
className={isLoading ? 'loading cg-executing' : ''} | |||
className={isLoading ? 'loading cg-executing test-fast-refresh' : ''} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did this change come from? Seems unrelated
I have read the CLA Document and I hereby sign the CLA |
recheck |
Remove babel dependencies since they're no longer needed. JSX transpilation is handled by esbuild in both dev and prod environments.
Changes:
Link to Devin run: https://app.devin.ai/sessions/890ff2c6911c4deca56725412876c792