Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): fix save state in human annotations when null or invalid #3185

Merged
merged 6 commits into from
Dec 12, 2024

Conversation

gtarpenning
Copy link
Member

@gtarpenning gtarpenning commented Dec 10, 2024

Description

https://wandb.atlassian.net/browse/WB-22273

This pr fixes 3 bugs in the human annotation flow:

  1. When inputting invalid integers in the numeric fields, occasionally the save button is still allowed, which then saves the last valid number. This can be different than what is displayed.
  2. After changing a value in a human feedback field, update the default to properly allow re-saving of the previous value. This re-queries for all the feedback, which should be fast, but we might need to revisit this.
  3. Disable the save button when feedback is null. Specifically, when a valid input is deleted, disable the button.

Testing

test field feedback

@gtarpenning gtarpenning changed the title Griffin/human annotation number bug chore(ui): fix save state in human annotations when null or invalid Dec 10, 2024
@circle-job-mirror
Copy link

@gtarpenning gtarpenning marked this pull request as ready for review December 10, 2024 17:11
@gtarpenning gtarpenning requested review from a team as code owners December 10, 2024 17:11
@gtarpenning gtarpenning enabled auto-merge (squash) December 12, 2024 01:55
@gtarpenning gtarpenning merged commit 3acb3d3 into master Dec 12, 2024
118 of 120 checks passed
@gtarpenning gtarpenning deleted the griffin/human-annotation-number-bug branch December 12, 2024 02:10
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants