Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(weave): simple prompt classes #3032

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

jamie-rasmussen
Copy link
Collaborator

Description

https://wandb.atlassian.net/browse/WB-20795
https://wandb.atlassian.net/browse/WB-20796

Flesh out simple first-class prompt objects, re-enable in docs and sidebar.

Testing

How was this PR tested?

@circle-job-mirror
Copy link

circle-job-mirror bot commented Nov 20, 2024

@jamie-rasmussen jamie-rasmussen marked this pull request as ready for review November 20, 2024 18:53
@jamie-rasmussen jamie-rasmussen requested review from a team as code owners November 20, 2024 18:53
Copy link
Collaborator

@tssweeney tssweeney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This appears to me to work exactly how our conversation with Shawn implied. I'd love a second check from him since last time I approved it was premature.

@jamie-rasmussen jamie-rasmussen merged commit 98c54ca into master Nov 21, 2024
114 of 116 checks passed
@jamie-rasmussen jamie-rasmussen deleted the jamie/simple-prompt-cp branch November 21, 2024 16:34
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants