Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): create ToggleButtonGroup component #2995

Merged
merged 14 commits into from
Nov 22, 2024
Merged

feat(ui): create ToggleButtonGroup component #2995

merged 14 commits into from
Nov 22, 2024

Conversation

molliean
Copy link
Contributor

@molliean molliean commented Nov 15, 2024 •
edited
Loading

Description

Creates ToggleButtonGroup common component.

https://www.figma.com/design/01KWBdMZg5QM9SRS1pQq0z/Design-System----Robot-Styles?m=auto&node-id=12323-59672&t=GB4Y5hz8mGnYWOfC-1

Allows users to select a single option from a set of toggle buttons. It supports three sizes (small, medium, and large), optional icons, and disabled states. It must have at least two options.

ToggleButtonGroup is built on Radix UI's Toggle Group.

Testing

Tested in Storybook (will be in separate core PR):

Screen.Recording.2024-11-22.at.9.57.13.AM.mov

How was this PR tested?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@circle-job-mirror
Copy link

circle-job-mirror bot commented Nov 15, 2024 •
edited
Loading

Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=0fa91f2fef7ed3675e6758a93d8586520467c7db

@molliean
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Nov 20, 2024
@github-actions
@molliean has signed the CLA in #2995
1769aad
@socket-security Socket Security
Copy link

socket-security bot commented Nov 20, 2024 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@radix-ui/[email protected] None +12 270 kB vladmoroz
npm/@radix-ui/[email protected] None 0 13.2 kB vladmoroz

View full report↗︎

@molliean molliean marked this pull request as ready for review November 20, 2024 21:04
@molliean molliean requested review from a team as code owners November 20, 2024 21:04
ericakdiaz
ericakdiaz approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@ericakdiaz ericakdiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just one small nit left :)

@molliean molliean merged commit dc4d654 into master Nov 22, 2024
113 of 115 checks passed
@molliean molliean deleted the molliean/toggle-button-group-common-component branch November 22, 2024 18:29
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericakdiaz ericakdiaz ericakdiaz approved these changes

@jamie-rasmussen jamie-rasmussen jamie-rasmussen approved these changes

@adityachoudhari26 adityachoudhari26 adityachoudhari26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@molliean @adityachoudhari26 @jamie-rasmussen @ericakdiaz