chore(ui): basic human feedback rendering in calls table #2991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtarpenning
commented
Nov 14, 2024
weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallPage/cost/costUtils.ts
Outdated
Show resolved
Hide resolved
jwlee64
reviewed
Nov 14, 2024
weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallPage/cost/costUtils.ts
Outdated
Show resolved
Hide resolved
gtarpenning
changed the title
tssweeney
reviewed
Nov 18, 2024
tssweeney
reviewed
Nov 18, 2024
weave-js/src/components/PagePanelComponents/Home/Browse3/filters/common.ts
Outdated
Show resolved
Hide resolved
tssweeney
reviewed
Nov 18, 2024
weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallsPage/callsTableColumns.tsx
Outdated
Show resolved
Hide resolved
tssweeney
reviewed
Nov 18, 2024
weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallsPage/callsTableColumns.tsx
Outdated
Show resolved
Hide resolved
tssweeney
reviewed
Nov 18, 2024
weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallsPage/callsTableColumns.tsx
Outdated
Show resolved
Hide resolved
tssweeney
reviewed
Nov 18, 2024
weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallsPage/callsTableColumns.tsx
Outdated
Show resolved
Hide resolved
tssweeney
reviewed
Nov 18, 2024
weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallsPage/callsTableQuery.ts
Outdated
Show resolved
Hide resolved
tssweeney
reviewed
Nov 18, 2024
weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallsPage/callsTableQuery.ts
Outdated
Show resolved
Hide resolved
tssweeney
reviewed
Nov 18, 2024
weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallsPage/callsTableQuery.ts
Outdated
Show resolved
Hide resolved
tssweeney
reviewed
Nov 19, 2024
| const field = inputField.startsWith('summary.weave.feedback') | ||
| ? inputField.replace('summary.weave.feedback.', '') | ||
| : inputField; | ||
| const deBracketed = field.replace(/\[.*\]/g, ''); |
There was a problem hiding this comment.
the fact that this is looking for a bracket does not make sense to me given the comment above
There was a problem hiding this comment.
i think this is just a no-op right now
There was a problem hiding this comment.
ill update the comment, but I am using this fn in one place where we go from backend filter -> displayName
export const getFieldLabel = (field: string): string => {
if (field.startsWith('feedback.')) {
// Here the field is coming from convertFeedbackFieldToBackendFilter
// so the field should start with 'feedback.' if feedback
const parsed = parseFeedbackType(field);
if (parsed === null) {
return field;
}
return parsed.displayName;
}
return FIELD_LABELS[field] ?? field;
};There was a problem hiding this comment.
hmmm, i would probably split those, but sure. It seems like a sufficiently different case
There was a problem hiding this comment.
hmmm, i would probably split those, but sure. It seems like a sufficiently different case
tssweeney
approved these changes
Nov 19, 2024
gtarpenning
commented
Dec 5, 2024
| @@ -108,11 +109,12 @@ export const useCallsForQuery = ( | |||
| { | |||
| skip: calls.loading, | |||
| includeCosts: true, | |||
| includeFeedback: true, | |||
There was a problem hiding this comment.
includeFeedback: true,
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MVP pr to combine feedback into the main calls data object.
https://wandb.atlassian.net/browse/WB-21666
Testing
How was this PR tested?