chore(weave): Add weave_ts, dev, and app scopes
#2810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=7a33f88f2d21c654eb5750e6fdc29c012c2cad7b |
jamie-rasmussen
approved these changes
Oct 29, 2024
andrewtruong
changed the title
|
Aren't those UI changes? |
andrewtruong
changed the title
weave_ts, dev, and app scopes
Yes. What I would like to do is reduce friction for contributors coming from the models side of the house. They will by habit be used to specifying "app" for frontend changes. For us, the distinction between common components and the Weave UI is probably not that useful of one to make, though maybe it serves as a bit of a hint to reflect on whether your change might affect the core app. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.