Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): add info icon to describe file and media are not in bytes stored #2764

Merged
merged 11 commits into from
Oct 31, 2024

Conversation

harukatab
Copy link
Contributor

Description

  • Fixes WB-NNNNN
  • Fixes #NNNN

What does the PR do? Include a concise description of the PR contents.

  • add an info icon that shows "This doesn't account for file and media sizes."
Screenshot 2024-10-23 at 11 26 08 AM
Screen.Recording.2024-10-23.at.11.13.48.AM.mov

Testing

How was this PR tested?

@circle-job-mirror
Copy link

circle-job-mirror bot commented Oct 23, 2024

@harukatab harukatab marked this pull request as ready for review October 23, 2024 18:51
@harukatab harukatab requested review from a team as code owners October 23, 2024 18:51
@adrnswanberg
Copy link
Contributor

I would say something like "This does not take into account any files or media logged in this trace."

weave-js/src/components/BytesStoredInfoIcon.tsx Outdated Show resolved Hide resolved
weave-js/src/components/BytesStoredInfoIcon.tsx Outdated Show resolved Hide resolved
@harukatab harukatab merged commit 5bd4d37 into master Oct 31, 2024
114 of 116 checks passed
@harukatab harukatab deleted the haruka/info-byte-storage branch October 31, 2024 00:31
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants