Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(weave): Add docs to CI and build process #2682

Merged
merged 7 commits into from
Oct 11, 2024
Merged

Conversation

andrewtruong
Copy link
Collaborator

No description provided.

@circle-job-mirror
Copy link

circle-job-mirror bot commented Oct 11, 2024

Copy link

@andrewtruong andrewtruong marked this pull request as ready for review October 11, 2024 22:38
@andrewtruong andrewtruong requested a review from a team as a code owner October 11, 2024 22:38
npm install

docs:
cd docs && make generate_all
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one note: generate_all hits the live server AND the frontend app. This means every single commit will trigger a few pings. Probably fine, but a bit fragile

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the alternative?

@andrewtruong andrewtruong merged commit 998cb18 into master Oct 11, 2024
99 checks passed
@andrewtruong andrewtruong deleted the andrew/docs-build branch October 11, 2024 23:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants