fix: Evaluations no longer associate incorrect inputs with predictions #2676
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced a bug: #2434 which resulted in the
predict_and_score
(and child calls) having an incorrect input refs getting assigned to the input. The result is that the inputs are effectively all the same (however the outputs are different). This results in a number of odd effects since the system thinks all the predictions are against the same row:So, what was the issue here? Well a classic case of mutating a closure variable before executing the function! duh!
For more details, consider this basic example:
Since the execution of the function is delayed, by the time the inner function executes,
ndx
has been changed!. Changing parallelism to 0 fixes this (since thedefer
becomes an immediate blocking call).I double checked everywhere and there are no other such cases of this pattern. Interestingly, @andrewtruong and I basically discussed this exact thing in extensive detail when he reviewed the original PR. We wrote tests and everything. I just missed this one call site!