Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Add additional numerical types for table formatting #2670

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

domphan-wandb
Copy link
Contributor

@domphan-wandb domphan-wandb commented Oct 10, 2024

Description

I noticed one of my tables didn't have correct formatting on numerical columns. Didn't realize there were additional numerical types. This PR adds a type check for float and int to set the column formatting.

Before
image

After
image

Testing

How was this PR tested?
Visually

@domphan-wandb domphan-wandb requested review from a team as code owners October 10, 2024 22:15
@circle-job-mirror
Copy link

circle-job-mirror bot commented Oct 10, 2024

@domphan-wandb domphan-wandb merged commit ac06747 into master Oct 14, 2024
99 checks passed
@domphan-wandb domphan-wandb deleted the dom/fix-add-types-col-format branch October 14, 2024 17:00
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants