Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(weave): Move weave python under sdk #2648

Closed
wants to merge 11 commits into from
Closed

Conversation

andrewtruong
Copy link
Collaborator

@andrewtruong andrewtruong commented Oct 9, 2024

  1. Moves the weave python code and tests under sdks/python in prep for other langs The README.md and LICENSE are symlinked from sdks/python to the repo root for now
  2. Keeps weave/clear_cache.py for compat

@andrewtruong andrewtruong force-pushed the andrew/reposhift branch 4 times, most recently from 199ccd9 to 540ea30 Compare October 11, 2024 23:46
@andrewtruong andrewtruong marked this pull request as ready for review October 12, 2024 00:23
@andrewtruong andrewtruong requested a review from a team as a code owner October 12, 2024 00:23
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This move is going to break local builds again

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it breaks helm, yeah good point.

Gonna keep clear_cache.py where it is and leave a note.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you might want to modify the docker file to actually load from weave_query dir, rather than this file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm... ok. no more changes needed here... but FWIW, my understanding is that:

  1. https://github.com/wandb/core/blame/master/onprem/local/Dockerfile#L46 -> this docker file puts the file at the correct weave/clear_cache.py dir
  2. https://github.com/wandb/helm-charts/blob/main/charts/operator-wandb/charts/weave/templates/deployment.yaml#L93 picks that up.

Implied by your comment is that https://github.com/wandb/helm-charts/blob/main/charts/operator-wandb/charts/weave/templates/deployment.yaml#L93 relies on clear_cache.py being in this repository at this location, but i am not sure that is true.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not actually a delete. It was moved to sdks/python and then symlinked back here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not actually a delete. It was moved to sdks/python and then symlinked back here

@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants