chore(ui): make eval section header draggable #2637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=a8e89e17fd055799ad1765469c0d45cabcde6440 |
gtarpenning
changed the title
gtarpenning
commented
Oct 10, 2024
.../PagePanelComponents/Home/Browse3/pages/CompareEvaluationsPage/compareEvaluationsContext.tsx
Outdated
Show resolved
Hide resolved
gtarpenning
changed the title
tssweeney
reviewed
Nov 25, 2024
...-js/src/components/PagePanelComponents/Home/Browse3/pages/CompareEvaluationsPage/ecpState.ts
Outdated
Show resolved
Hide resolved
tssweeney
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
I'm noticing that the shopping cart items have the "Click to select this item" tooltip / cursor / hover effect but it appears you can't actually click to do the subselection as you can in the generic comparison view.
I also think we still want the colored circle and the id value to show in the item?
...s/src/components/PagePanelComponents/Home/Browse3/pages/common/shoppingCart/ShoppingCart.tsx
Outdated
Show resolved
Hide resolved
| <span>{call.displayName ?? call.spanName}</span> | ||
| <Id id={call.callId} type="Call" className="ml-0 mr-4" /> | ||
| <span | ||
| style={{ |
There was a problem hiding this comment.
I think it would be nice if we start using Tailwind for stuff like this but no need to change now.
jamie-rasmussen
approved these changes
Dec 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drag around the Eval buttons, to set the order of how the evaluations appear in the evaluation compare page.