chore(weave): add width to autocomplete #2500
Conversation
mbarrramsey
changed the title
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=ea392036e1d0254d80489d8695d6b2d023a32e3e |
| hasInputValue?: boolean; | ||
| inputRef?: React.MutableRefObject<HTMLDivElement | null>; |
There was a problem hiding this comment.
suggestion: inputRef naming seems misleading if it's actually a div element under there? maybe should be named something else
There was a problem hiding this comment.
Maybe inputDivRef? or autocompleteDivRef?
There was a problem hiding this comment.
we should probably leave out "input" entirely. if you inspect the elements, there's an actual input element nested inside, but this ref is definitely not being attached to that.
have you tried React.forwardRef()?
There was a problem hiding this comment.
I did try the forwardRef, but I don't think it works well with generics 🤔 see https://github.com/wandb/core/pull/24247/files#r1777844929. We could try using the wrapper approach but it seems like the custom name is similar?
There was a problem hiding this comment.
ahh i see. maybe something like containerRef or autocompleteRef seems fine then!
mbarrramsey
force-pushed
the
mbarrramsey/add_ref_autocomplete
branch
from
e395283 to
109d047
Compare
Description
Adds minWidth param and ref to the autocomplete component so we can measure the full width of the text input for use in https://github.com/wandb/core/pull/24247.
Testing
How was this PR tested?