Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(weave): Legacy Refactor pt23 #2241

Closed
wants to merge 17 commits into from
Closed

Conversation

andrewtruong
Copy link
Collaborator

@andrewtruong andrewtruong commented Aug 27, 2024

Split out from: #2182

This slice splits out:

  • mypy.ini into respective trace and legacy configs
  • test_weave_api -- trace and legacy tests stuck in 1 file

It also:

  • Creates a copy of ref_util for trace
  • Deletes remaining trace code in the legacy api.

@andrewtruong andrewtruong requested a review from a team as a code owner August 27, 2024 04:58
@circle-job-mirror
Copy link

circle-job-mirror bot commented Aug 27, 2024

* more work

* adding

* linting

* some of the UI fixes

* tests - rough

* lint complete

* test improvement

* done with tests

* ok, basically done

* Final

* Final

* Final

* Final

* Final

* i think complete

* test fix

* removed client check

* added checks

* another little fix

* done

* lint

* comments
Base automatically changed from andrew/ref22 to andrew/ref21 August 28, 2024 19:12
Base automatically changed from andrew/ref21 to andrew/ref20 August 28, 2024 19:12
gtarpenning and others added 8 commits August 28, 2024 20:40
* move to legacy: query_api

* move to legacy: server

* move to legacy: environment

* move to legacy: errors (and add relevant errors to trace)

* move to legacy: storage

* move to legacy: logs

* move to legacy: urls

* move to legacy: util

* move to legacy: filesystem

* move to legacy: weave_http

* move to legacy: weave_types

* move to legacy: weave_internal

* move to legacy: test_stream_table

* move to legacy: perf_notebooks

* move to legacy: internal_tools

* move to legacy: dispatching_and_resolution

* move to trace: init_message

* move to trace: weave_init

* move to trace: cli

* move to trace: client_context

* delete: extraneous files

* delete: api; split out trace and query api from single api file

* move to legacy: legacy tests

* move to legacy: legacy test_utils

* move to legacy: old query panel examples and notebooks

* move to legacy: makefile

* !!! move files from weave/legacy -> weave/legacy/weave to match new repo

* move to legacy: pytest_parallel

* move to legacy: wandb_artifact_perf

* move to legacy: utils

* move to legacy: tutorial_scripts

* move to legacy: pytest

* move to legacy: build_dist

* move to legacy: docker stuff

* move to legacy: mutations-perf

* move to legacy: manifest

* move to dev_docs: dev_docs (also move legacy settings and devcontainer)

* move to scripts: auth_modes (also split out jupyter dev script)

* delete: useless pyright config

* move to legacy: test_server

* cleanup: missing imports

* split: further split trace and legacy errors

* split: make separate trace and legacy utils

* delete: extraneous import

* lint

* bump
Copy link
Contributor

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


2 out of 3 committers have signed the CLA.
@gtarpenning
@andrewtruong
@weave Build Bot
Weave Build Bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@andrewtruong
Copy link
Collaborator Author

closing in favor of: #2272

@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants