-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(weave): Legacy Refactor pt18 #2236
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=ff70734ff8cd55dc371600ab22c9cd2e49aee6ad |
andrewtruong
force-pushed
the
andrew/ref18
branch
from
August 27, 2024 04:38
eee78ed
to
b5a05e6
Compare
andrewtruong
force-pushed
the
andrew/ref17
branch
2 times, most recently
from
August 27, 2024 14:22
4ab29e5
to
08acd17
Compare
andrewtruong
force-pushed
the
andrew/ref18
branch
from
August 27, 2024 14:23
b5a05e6
to
921f85e
Compare
andrewtruong
force-pushed
the
andrew/ref17
branch
from
August 27, 2024 16:25
08acd17
to
99ed178
Compare
andrewtruong
force-pushed
the
andrew/ref18
branch
from
August 27, 2024 16:26
921f85e
to
d80ecec
Compare
andrewtruong
force-pushed
the
andrew/ref17
branch
from
August 28, 2024 01:00
99ed178
to
0f79fe1
Compare
andrewtruong
force-pushed
the
andrew/ref18
branch
from
August 28, 2024 01:01
d80ecec
to
a5ce120
Compare
andrewtruong
force-pushed
the
andrew/ref17
branch
from
August 28, 2024 02:24
0f79fe1
to
47425c4
Compare
andrewtruong
force-pushed
the
andrew/ref18
branch
from
August 28, 2024 02:25
a5ce120
to
879dcdf
Compare
tssweeney
approved these changes
Aug 28, 2024
andrewtruong
added a commit
that referenced
this pull request
Aug 28, 2024
* move to trace: init_message * move to trace: weave_init * move to trace: cli * move to trace: client_context * chore(weave): Legacy Refactor pt18 (#2236) * delete: extraneous files * delete: api; split out trace and query api from single api file * move to legacy: legacy tests * move to legacy: legacy test_utils * move to legacy: old query panel examples and notebooks * move to legacy: makefile * !!! move files from weave/legacy -> weave/legacy/weave to match new repo (#2237)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from: #2182
This slice moves the following to
legacy
:legacy tests
legacy test_utils
old query panel examples and notebooks
makefile
And deletes:
api.py
, splitting out the trace and query apis into their respectiveapi.py