dnm: legacy-split1

.github/workflows/cla.yaml

@@ -3,7 +3,7 @@ on:
   issue_comment:
     types: [created]
   pull_request_target:
-    types: [opened,closed,synchronize]
+    types: [opened, closed, synchronize]
 
 # explicitly configure permissions, in case your GITHUB_TOKEN workflow permissions are set to read-only in repository settings
 permissions:
@@ -22,9 +22,9 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
-          path-to-signatures: 'cla/signatures/version1/cla.json'
-          path-to-document: 'https://github.com/wandb/weave/blob/master/cla/cla.md' # e.g. a CLA or a DCO document
+          path-to-signatures: "cla/signatures/version1/cla.json"
+          path-to-document: "https://github.com/wandb/weave/blob/master/dev_docs/cla.md" # e.g. a CLA or a DCO document
           # branch should not be protected
-          branch: 'cla'
+          branch: "cla"
           # cannot use teams due to: https://github.com/contributor-assistant/github-action/issues/100
           allowlist: actions-user, altay, bdytx5, dannygoldstein, davidwallacejackson, jamie-rasmussen, jlzhao27, jo-fang, jwlee64, laxels, morganmcg1, nickpenaranda, scottire, shawnlewis, staceysv, tssweeney, vanpelt, vwrj, wandbmachine

.github/workflows/test.yaml

@@ -35,9 +35,9 @@ jobs:
       - name: Prune docker cache
         run: docker system prune -f
       - name: Build unit test image
-        run: python3 docker_build.py build_deps weave-test builder . Dockerfile.test
+        run: python3 weave/legacy/docker_build.py build_deps weave-test builder . weave/legacy/Dockerfile.test
       - name: Build integration test image
-        run: python3 docker_build.py build weave-integration-test . Dockerfile.test
+        run: python3 weave/legacy/docker_build.py build weave-integration-test . weave/legacy/Dockerfile.test
 
   lint:
     name: Python lint
@@ -125,15 +125,42 @@ jobs:
           DD_SERVICE: weave-python
           DD_ENV: ci
           WEAVE_SENTRY_ENV: ci
+          CI: 1
+          WB_SERVER_HOST: http://wandbservice
+          WF_CLICKHOUSE_HOST: weave_clickhouse
+          WEAVE_SERVER_DISABLE_ECOSYSTEM: 1
         # This runner specifically runs the tests that use the `client` fixture (those that support clickhouse client tests)
         # However, we skip tests marked with `skip_clickhouse_client`. These should be considered TODOs and an exception
-        run: CI=1 WB_SERVER_HOST=http://wandbservice WF_CLICKHOUSE_HOST=weave_clickhouse WEAVE_SERVER_DISABLE_ECOSYSTEM=1 source /root/venv/bin/activate && cd weave && pytest -m "weave_client and not skip_clickhouse_client" --weave-server=clickhouse --job-num=${{ matrix.job_num }} --timeout=90  ./flow ./integrations ./tests ./legacy/ops_arrow ./legacy/ecosystem ./trace_server ./trace --ddtrace --durations=5
+        run: |
+          source /root/venv/bin/activate && \
+          cd weave && \
+          pytest -m "weave_client and not skip_clickhouse_client" \
+          --weave-server=clickhouse \
+          --job-num=${{ matrix.job_num }} \
+          --timeout=90 \
+          --ddtrace \
+          --durations=5 \
+          ./integrations ./legacy ./trace_server ./trace ./tests
       - name: Run Python Unit Tests
         env:
           DD_SERVICE: weave-python
           DD_ENV: ci
           WEAVE_SENTRY_ENV: ci
-        run: CI=1 WB_SERVER_HOST=http://wandbservice WF_CLICKHOUSE_HOST=weave_clickhouse WEAVE_SERVER_DISABLE_ECOSYSTEM=1 source /root/venv/bin/activate && pip install 'dspy-ai>=0.1.5' && pip install pydantic -U  && cd weave && pytest --job-num=${{ matrix.job_num }} --timeout=90  ./flow ./integrations ./tests ./legacy/ops_arrow ./legacy/ecosystem ./trace_server ./trace --ddtrace --durations=5
+          CI: 1
+          WB_SERVER_HOST: http://wandbservice
+          WF_CLICKHOUSE_HOST: weave_clickhouse
+          WEAVE_SERVER_DISABLE_ECOSYSTEM: 1
+        run: |
+          source /root/venv/bin/activate && \
+          pip install 'dspy-ai>=0.1.5' && \
+          pip install pydantic -U && \
+          cd weave && \
+          pytest \
+          --job-num=${{ matrix.job_num }} \
+          --timeout=90 \
+          --ddtrace \
+          --durations=5 \
+          ./integrations ./legacy ./trace_server ./trace ./tests
 
   # nbmake:
   #   name: Run notebooks with nbmake
@@ -186,7 +213,7 @@ jobs:
         # github actions does something funky with the std file descriptors, they end up
         # being closed. tqdm (for example) raises an exception when the descriptor it
         # wants to write to is closed.
-        run: nohup ./weave_server_test.sh < /dev/null &> /tmp/weave/log/stdout.log &
+        run: nohup ./scripts/weave_server_test.sh < /dev/null &> /tmp/weave/log/stdout.log &
         shell: bash
       - name: Cypress run
         # Use the following to run just a single test

.pre-commit-config.yaml

@@ -15,15 +15,47 @@ repos:
     rev: "v1.10.0"
     hooks:
       - id: mypy
+        name: mypy (trace)
         additional_dependencies:
-          [types-pkg-resources==0.1.3, types-all, wandb>=0.15.5]
+          [types-pkg-resources==0.1.3, types-all==1.0.0, wandb>=0.15.5]
+        exclude: >
+          (?x)^(
+            .*\.pyi$
+            |weave/tests/
+            |weave/trace_server/tests/
+            |weave/legacy/
+            |integration_test/
+          )
+      - id: mypy
+        name: mypy (legacy)
+        additional_dependencies:
+          [
+            types-pkg-resources==0.1.3,
+            types-all==1.0.0,
+            types-setuptools,
+            wandb>=0.15.5,
+          ]
+        files: ^weave/legacy/
         # You have to exclude in 3 places. 1) here. 2) mypi.ini exclude, 3) follow_imports = skip for each module in mypy.ini
-        exclude: (.*pyi$)|(weave/legacy)|(weave/tests)
-  # Turn pyright back off, duplicative of mypy
-  # - repo: https://github.com/RobertCraigie/pyright-python
-  #   rev: v1.1.341
-  #   hooks:
-  #   - id: pyright
+        exclude: >
+          (?x)^(
+            .*\.pyi$
+            |weave/legacy/tests/
+            |weave/legacy/weave/ecosystem/
+            |weave/legacy/weave/panel/
+            |weave/legacy/weave/panels/
+            |weave/legacy/weave/panels_py/
+            |weave/legacy/weave/ops/
+            |weave/legacy/weave/ops_domain/
+            |weave/legacy/weave/ops_arrow/
+            |weave/legacy/weave/ops_primitives/
+            |weave/legacy/weave/monitoring/
+            |weave/trace/
+            |weave/trace_server/
+            |weave/flow/
+            |weave/integrations/
+          )
+        args: [--config-file=weave/legacy/mypy.ini]
   - repo: local
     hooks:
       - id: jupyter-nb-clear-output