fix: Fixes issues with special characters in object name #2156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tssweeney
commented
Aug 16, 2024
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=a8044212762b171870e48cf5416740397dcd97d1 |
tssweeney
commented
Aug 17, 2024
weave/weave_client.py
Outdated
| # Replaces any non-alphanumeric characters with a single dash and removes | ||
| # any leading or trailing dashes. This is more restrictive than the DB | ||
| # constraints and can be relaxed if needed. | ||
| res = re.sub(r"[._-]+", "-", re.sub(r"[^\w._]+", "-", name)).strip("-_") |
There was a problem hiding this comment.
i am wondering if this will result in any changes to integration names?
tssweeney
commented
Aug 17, 2024
| @@ -57,7 +58,20 @@ def wb_run_id_validator(s: typing.Optional[str]) -> typing.Optional[str]: | |||
| return s | |||
|
|
|||
|
|
|||
| def _validate_object_name_charset(name: str) -> None: | |||
| # Object names must be alphanumeric with dashes | |||
| invalid_chars = re.findall(r"[^\w._-]", name) | |||
There was a problem hiding this comment.
This is quite restrictive - could frustrate people?
tssweeney
commented
Aug 27, 2024
| @@ -34,7 +34,7 @@ describe('parseRef', () => { | |||
| }); | |||
| it('parses a ref with spaces in entity', () => { | |||
| const parsed = parseRef( | |||
| 'weave:///Entity%20Name/project/object/artifact-name:artifactversion' | |||
| 'weave:///Entity Name/project/object/artifact-name:artifactversion' | |||
There was a problem hiding this comment.
This was not a valid ref - in fact it was a bug in ref creation from Browse3
tssweeney
commented
Aug 27, 2024
| @@ -102,20 +102,6 @@ describe('parseRef', () => { | |||
| weaveKind: 'object', | |||
| }); | |||
| }); | |||
| it('parses a ref with escaped spaces in name and projectName', () => { | |||
There was a problem hiding this comment.
Same here, not a valid ref
|
Attaching this ticket from triage to this pr, curly braces should be supported. |
This PR should sanitize these away |
gtarpenning
approved these changes
Aug 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified version of #2145 that takes a different approach to fixing the problem by implementing constraints on the names rather than url encoding.
Allowed characters:
\w._-This PR does 3 things:
Browse3to use decoded params from the URL, which avoids creating invalid refs on UI side.The effective result of this is:
Deployment can be an any order, hence a common PR to centralize all these changes