Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Python Docs: Link to source, better pydantic objects #2102

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

tssweeney
Copy link
Collaborator

@tssweeney tssweeney commented Aug 9, 2024

Adds:

  • Link to source code
  • Better support for objects inheriting from BaseModel
Screenshot 2024-08-09 at 13 55 29

@tssweeney tssweeney marked this pull request as ready for review August 9, 2024 20:58
@tssweeney tssweeney requested a review from a team as a code owner August 9, 2024 20:58

def generate_module_doc_string(
module,
src_root_path="/Users/timothysweeney/Workspace/github/wandb/core/services/weave-python/weave-public/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a different root path here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice - fixing.

Copy link
Contributor

@jwlee64 jwlee64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the one comment lgtm

@circle-job-mirror
Copy link

@tssweeney tssweeney enabled auto-merge (squash) August 9, 2024 21:26
@tssweeney tssweeney merged commit 4f7df0a into master Aug 9, 2024
27 checks passed
@tssweeney tssweeney deleted the tim/pydocs_round_two branch August 9, 2024 21:41
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants