Skip to content

Commit

Permalink
pr comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jwlee64 committed Dec 14, 2024
1 parent 9738161 commit fc5e18c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions weave/trace_server/llm_completion.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
)
from weave.trace_server.secret_fetcher_context import _secret_fetcher_context

nova_models = ["nova-pro-v1", "nova-lite-v1", "nova-micro-v1"]
NOVA_MODELS = ("nova-pro-v1", "nova-lite-v1", "nova-micro-v1")


def lite_llm_completion(
Expand All @@ -21,7 +21,7 @@ def lite_llm_completion(
get_bedrock_credentials(inputs.model)
)
# Nova models need the region in the model name
if any(x in inputs.model for x in nova_models) and aws_region_name:
if any(x in inputs.model for x in NOVA_MODELS) and aws_region_name:
aws_inference_region = aws_region_name.split("-")[0]
inputs.model = "bedrock/" + aws_inference_region + "." + inputs.model
# XAI models don't support response_format
Expand Down

0 comments on commit fc5e18c

Please sign in to comment.