chore: make mypy work

.pre-commit-config.yaml

@@ -17,7 +17,7 @@ repos:
       - id: mypy
         name: mypy (trace)
         additional_dependencies:
-          [types-pkg-resources==0.1.3, types-all, wandb>=0.15.5]
+          [types-pkg-resources==0.1.3, types-all==1.0.0, wandb>=0.15.5]
         exclude: >
           (?x)^(
             .*\.pyi$
@@ -26,22 +26,36 @@ repos:
             |weave/legacy/
             |integration_test/
           )
-      # TODO: Turn on legacy mypy on split out; not doing for now bc too complicated.
-      # - id: mypy
-      #   name: mypy (legacy)
-      #   additional_dependencies:
-      #     [types-pkg-resources==0.1.3, types-all, wandb>=0.15.5]
-      #   files: ^weave/legacy
-      #   # You have to exclude in 3 places. 1) here. 2) mypi.ini exclude, 3) follow_imports = skip for each module in mypy.ini
-      #   exclude: >
-      #     (?x)^(
-      #       .*\.pyi$
-      #       |weave/legacy/tests/
-      #       |weave/legacy/weave/ecosystem/
-      #       |weave/legacy/weave/panel/
-      #       |weave/legacy/weave/ops/
-      #     )
-      #   args: [--config-file=weave/legacy/mypy.ini]
+      - id: mypy
+        name: mypy (legacy)
+        additional_dependencies:
+          [
+            types-pkg-resources==0.1.3,
+            types-all==1.0.0,
+            types-setuptools,
+            wandb>=0.15.5,
+          ]
+        files: ^weave/legacy/
+        # You have to exclude in 3 places. 1) here. 2) mypi.ini exclude, 3) follow_imports = skip for each module in mypy.ini
+        exclude: >
+          (?x)^(
+            .*\.pyi$
+            |weave/legacy/tests/
+            |weave/legacy/weave/ecosystem/
+            |weave/legacy/weave/panel/
+            |weave/legacy/weave/panels/
+            |weave/legacy/weave/panels_py/
+            |weave/legacy/weave/ops/
+            |weave/legacy/weave/ops_domain/
+            |weave/legacy/weave/ops_arrow/
+            |weave/legacy/weave/ops_primitives/
+            |weave/legacy/weave/monitoring/
+            |weave/trace/
+            |weave/trace_server/
+            |weave/flow/
+            |weave/integrations/
+          )
+        args: [--config-file=weave/legacy/mypy.ini]
   - repo: local
     hooks:
       - id: jupyter-nb-clear-output

mypy.ini

@@ -1,11 +1,10 @@
 [mypy]
-plugins = mypy_weave_plugin.py
 warn_unused_configs = True
-exclude = (.*pyi$)|(weave/tests)|(weave/trace_server/tests)|(weave/legacy)
-
-;; we ignore ecosystem, tests, panel*, ops* for now. To do so you have
-;; 1. put in exclude above
-;; 2. put in follow_imports = skip below ;; 3. put in exclude in .pre-commit-config.yaml
+exclude = 
+    .*pyi$
+    |weave/tests
+    |weave/trace_server/tests
+    |weave/legacy
 
 ; Top-level rules
 [mypy-weave.*]