Skip to content

Commit

Permalink
chore(weave): Fix predict detection heuristic for evals (#3196)
Browse files Browse the repository at this point in the history
* init

* lint
  • Loading branch information
tssweeney authored Dec 11, 2024
1 parent f967984 commit 4e1e2c9
Showing 1 changed file with 1 addition and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@
* across different datasets.
*/

import _ from 'lodash';
import {sum} from 'lodash';
import {useEffect, useMemo, useRef, useState} from 'react';

Expand Down Expand Up @@ -479,17 +478,8 @@ const fetchEvaluationComparisonData = async (
const maybeDigest = parts[1];
if (maybeDigest != null && !maybeDigest.includes('/')) {
const rowDigest = maybeDigest;
const possiblePredictNames = [
'predict',
'infer',
'forward',
'invoke',
];
const isProbablyPredictCall =
(_.some(possiblePredictNames, name =>
traceCall.op_name.includes(`.${name}:`)
) &&
modelRefs.includes(traceCall.inputs.self)) ||
modelRefs.includes(traceCall.inputs.self) ||
modelRefs.includes(traceCall.op_name);

const isProbablyScoreCall = scorerRefs.has(traceCall.op_name);
Expand Down

0 comments on commit 4e1e2c9

Please sign in to comment.