Skip to content

Commit

Permalink
chore(weave): Refactor hotfixes4 (#2539)
Browse files Browse the repository at this point in the history
* test

* test

* test version

* test_version

* wow im bad at versions

* test

* test

* test

* test
  • Loading branch information
andrewtruong authored Sep 30, 2024
1 parent fd9cc2a commit 39265aa
Show file tree
Hide file tree
Showing 10 changed files with 12 additions and 16 deletions.
2 changes: 1 addition & 1 deletion .gitattributes
Original file line number Diff line number Diff line change
@@ -1 +1 @@
weave/frontend/** linguist-generated=true
weave_query/weave_query/frontend/** linguist-generated=true
6 changes: 3 additions & 3 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
workflow_dispatch:
inputs:
is_test:
description: "Use Test Pypi"
description: 'Use Test Pypi'
required: true
type: boolean
default: true
Expand All @@ -24,11 +24,11 @@ jobs:
fetch-depth: 0
- uses: actions/setup-node@v1
with:
node-version: "18.x"
node-version: '18.x'
- run: |
pip install build twine
./build_dist.py
if [[ -n "$(git status weave/frontend/sha1.txt --porcelain)" ]]
if [[ -n "$(git status weave_query/weave_query/frontend/sha1.txt --porcelain)" ]]
then
echo "::error cannot publish release, commited SHA does not match build SHA"
exit 1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/upload-assets.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- id: 'build'
run: |
./weave_query/weave_query/frontend/build.sh
if [[ -z "$(git status weave/frontend/sha1.txt --porcelain)" ]]
if [[ -z "$(git status weave_query/weave_query/frontend/sha1.txt --porcelain)" ]]
then
echo "Frontend assets has not changed, skipping publishing"
echo "UPLOAD_ASSETS=false" >> "$GITHUB_OUTPUT"
Expand Down
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ artifacts
local-artifacts
weave_internal.egg-info
weave.egg-info/
weave/frontend/assets
weave_query/weave_query/frontend/assets
build/
MNIST
food-101
Expand Down
3 changes: 1 addition & 2 deletions MANIFEST.in
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@ include wb_schema.gql
graft weave/client_context
graft weave/deploy
graft weave/flow
graft weave/frontend
graft weave_query/weave_query/frontend
graft weave/integrations
graft weave/legacy
graft weave/trace
graft weave/trace_server
graft weave/type_serializers
Expand Down
2 changes: 1 addition & 1 deletion build_dist.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
)

if os.getenv("WEAVE_SKIP_BUILD") == None:
subprocess.run(["bash", "weave/frontend/build.sh"], check=True)
subprocess.run(["bash", "weave_query/weave_query/frontend/build.sh"], check=True)
else:
print("!!! Skipping frontend build !!!")

Expand Down
4 changes: 0 additions & 4 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,6 @@ version = { attr = "weave.version.VERSION" }
dependencies = { file = ["requirements.txt"] }

[tool.setuptools.dynamic.optional-dependencies]
examples = { file = ["requirements.legacy.ecosystem.txt"] }
engine = { file = ["requirements.legacy.engine.txt"] }
ecosystem = { file = ["requirements.legacy.ecosystem.txt"] }
datadog = { file = ["requirements.legacy.datadog.txt"] }
modal = { file = ["requirements.modal.txt"] }

[tool.pytest.ini_options]
Expand Down
2 changes: 1 addition & 1 deletion scripts/build_frontend.sh
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
cd weave/frontend
cd weave_query/weave_query/frontend
sh build.sh
3 changes: 2 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from typing import Union
from urllib.error import HTTPError

from setuptools import setup # type: ignore[import]
from setuptools import find_namespace_packages, setup # type: ignore[import]
from setuptools.command.build import build # type: ignore[import]
from setuptools.command.editable_wheel import editable_wheel # type: ignore[import]
from setuptools.command.sdist import sdist # type: ignore[import]
Expand Down Expand Up @@ -116,4 +116,5 @@ def run(self) -> None:

setup(
cmdclass={"build": Build, "editable_wheel": EditableWheel, "sdist": Sdist},
packages=find_namespace_packages(include=["weave*"]),
)
2 changes: 1 addition & 1 deletion weave_query/.vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"python.testing.cwd": "./weave",
"python.formatting.provider": "black",
"search.exclude": {
"weave/frontend": true
"weave_query/weave_query/frontend": true
},
"files.insertFinalNewline": true,
"black-formatter.importStrategy": "fromEnvironment",
Expand Down

0 comments on commit 39265aa

Please sign in to comment.