Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some tweaks to @Initializer annotations in wala.util #1474

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Some tweaks to @Initializer annotations in wala.util #1474

merged 3 commits into from
Nov 26, 2024

Conversation

msridhar
Copy link
Member

  • Remove a couple of @Nullable annotations and add @Initializer instead, to better capture the protocol.
  • Remove WALA's custom @Initializer annotation and use the one from NullAway's annotations package, which we already depend on.

@msridhar msridhar requested a review from liblit November 26, 2024 21:17
@msridhar msridhar enabled auto-merge (squash) November 26, 2024 21:17
@github-actions GitHub Actions
Copy link

Test Results

  813 files  ±0    813 suites  ±0   4h 15m 13s ⏱️ + 33m 29s
  736 tests ±0    719 ✅ ±0   17 💤 ±0  0 ❌ ±0 
5 036 runs  ±0  4 915 ✅ ±0  121 💤 ±0  0 ❌ ±0 

Results for commit 58471b1. ± Comparison against base commit a44aa59.

@msridhar msridhar merged commit 6d62392 into wala:master Nov 26, 2024
10 checks passed
@msridhar msridhar deleted the remove-some-nullable-annots branch November 27, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liblit liblit liblit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msridhar @liblit