Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace some StringBuilders with String concatenation #1464

Merged
merged 2 commits into from
Nov 16, 2024

Conversation

liblit
Copy link
Contributor

@liblit liblit commented Nov 16, 2024

StringBuilder provides no benefit when building a String using just one concatenation.

`StringBuilder` provides no benefit when building a `String` using just
one concatenation.
@liblit liblit added the cleanup API cleanup and refactoring label Nov 16, 2024
@liblit liblit requested a review from msridhar November 16, 2024 19:44
@liblit liblit self-assigned this Nov 16, 2024
@liblit liblit enabled auto-merge (rebase) November 16, 2024 19:44
Copy link

Test Results

  813 files  ±0    813 suites  ±0   4h 3m 31s ⏱️ + 5m 41s
  735 tests ±0    718 ✅ ±0   17 💤 ±0  0 ❌ ±0 
5 029 runs  ±0  4 908 ✅ ±0  121 💤 ±0  0 ❌ ±0 

Results for commit affe403. ± Comparison against base commit 6909f8e.

@liblit liblit merged commit 7be9fb5 into wala:master Nov 16, 2024
10 checks passed
@liblit liblit deleted the replace-StringBuilder-with-String branch November 16, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup API cleanup and refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants