Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Error Prone to 2.35.1 and enable javac -parameters flag #1458

Merged
merged 1 commit into from
Nov 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ tasks.withType<JavaCompile>().configureEach {
error("UnusedVariable")
error("JdkObsolete")
error("AnnotationPosition")
error("AssertEqualsArgumentOrderChecker")
error("ArgumentSelectionDefectChecker")
// checks we do not intend to try to fix in the near-term:
// Just too many of these; proper Javadoc would be a great long-term goal
disable("MissingSummary")
Expand Down Expand Up @@ -120,6 +122,7 @@ tasks.withType<JavaCompile>().configureEach {
options.run {
encoding = "UTF-8"
compilerArgs.add("-Werror")
compilerArgs.add("-parameters")
}
}

Expand Down
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ eclipse-ecj = "org.eclipse.jdt:ecj:3.37.0"
eclipse-osgi = "org.eclipse.platform:org.eclipse.osgi:3.19.0"
eclipse-wst-jsdt-core = { module = "org.eclipse.wst.jsdt:core", version.ref = "eclipse-wst-jsdt" }
eclipse-wst-jsdt-ui = { module = "org.eclipse.wst.jsdt:ui", version.ref = "eclipse-wst-jsdt" }
errorprone-core = "com.google.errorprone:error_prone_core:2.34.0"
errorprone-core = "com.google.errorprone:error_prone_core:2.35.1"
gradle-download-task = "de.undercouch:gradle-download-task:5.6.0"
gradle-errorprone-plugin = "net.ltgt.gradle:gradle-errorprone-plugin:4.1.0"
gradle-goomph-plugin = "com.diffplug.gradle:goomph:3.44.0"
Expand Down
Loading