Simplify helper functions for native code #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `cast/helpers.kt` script defines various functions that help us configure tasks that work with native code, such as natively compiled libraries. I ported these from Groovy to Kotlin when I was still fairly new to the latter. I've gotten better with Kotlin since then, and I now see how some of these functions could be simplified. For example, judicious use of extension methods makes some functions easier to call, and also makes it easier for those functions' implementations to access properties of the receiver object. In other cases, some function parameters can be computed from other parameters, thereby making the function easier to call correctly and harder to call incorrectly. None of this constitutes a radical change to the suite of helper functions or how they are used to configure tasks. It's just a bunch of small cleanups and simplifications from 2024-me, who knows Kotlin better than 2022-me.
liblit
added
gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cast/helpers.ktscript defines various functions that help us configure tasks that work with native code, such as natively compiled libraries. I ported these from Groovy to Kotlin when I was still fairly new to the latter. I've gotten better with Kotlin since then, and I now see how some of these functions could be simplified.For example, judicious use of extension methods makes some functions easier to call, and also makes it easier for those functions' implementations to access properties of the receiver object. In other cases, some function parameters can be computed from other parameters, thereby making the function easier to call correctly and harder to call incorrectly.
None of this constitutes a radical change to the suite of helper functions or how they are used to configure tasks. It's just a bunch of small cleanups and simplifications from 2024-me, who knows Kotlin better than 2022-me.
Reviewer tip: ignore whitespace for a more semantic diff view.