Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClassHierarchy toJson Function #1392
base: master
Are you sure you want to change the base?
ClassHierarchy toJson Function #1392
Changes from all commits
1187f33
3a90899
6c81529
163aa8e
6f69ce9
307607a
cb5dd7b
b489343
a38c5b7
ab16227
a43b836
6d15461
e57b590
0f8f978
c237c76
fbe9c59
3cfff82
ebd73ae
89359aa
ed5500c
7036d90
9b7b7e9
a41401a
c7707eb
8b9c04d
15a4a1e
7729aa7
f777f66
efad143
016896e
c050542
dcb0652
ed87a3a
030e8b3
d09462c
9147bc8
474cbfd
2ec38a9
246e59a
c5256ab
050da9f
52574e6
9b52619
731deed
e6f43dd
5016ea2
8eb7723
f62575e
113b2a8
23412c2
65b08aa
1595369
9b8ac2e
b430981
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By printing out the JSON in the test and looking it over, I realized that it only handles subclassing, but not interface implementations. E.g., for the interface
java.util.Map
we see"java.util.Map":[]
in the output, missing all the classes that implement that interface. We should update this logic so that for interfaces, we treat all implementing classes and sub-interfaces as subtypes in the outputted JSON. In other words, the JSON should map each class or interface to all of its immediate subtypes, i.e., direct subclasses, direct sub-interfaces, or classes directly implementing an interface.