Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the function under test exists #197

Closed
wants to merge 5 commits into from

Conversation

khatchad
Copy link
Collaborator

Ensure that the function under test exists in the call graph. Otherwise, we could test a function that doesn't exist and the test will still pass.

khatchad added 2 commits June 13, 2024 16:50
Ensure that the function under test exists in the call graph. Otherwise,
we could test a function that doesn't exist and the test will still
pass.
@khatchad khatchad requested a review from msridhar June 13, 2024 21:15
@khatchad khatchad added bug Something isn't working testing Related to test code or test input labels Jun 13, 2024
@khatchad khatchad enabled auto-merge (squash) June 13, 2024 21:15
@khatchad
Copy link
Collaborator Author

Sorry, I'll fix the errors now.

@khatchad
Copy link
Collaborator Author

Ah, looks like I need to add more changes from our fork to get to this to work. I'll turn it into a draft PR for now.

@khatchad khatchad marked this pull request as draft June 14, 2024 13:56
auto-merge was automatically disabled June 14, 2024 13:56

Pull request was converted to draft

@msridhar msridhar removed their request for review August 9, 2024 17:16
@khatchad khatchad marked this pull request as ready for review November 11, 2024 19:24
@khatchad khatchad enabled auto-merge (squash) November 11, 2024 19:25
@khatchad khatchad added the invalid This doesn't seem right label Nov 11, 2024
@khatchad
Copy link
Collaborator Author

Empty PR.

@khatchad khatchad closed this Nov 11, 2024
auto-merge was automatically disabled November 11, 2024 19:57

Pull request was closed

@khatchad khatchad deleted the contrib_test_fut_existance branch November 11, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right testing Related to test code or test input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant