fix(store): limit dbPageSize #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LNSD
suggested changes
Jun 23, 2022
| @@ -267,8 +267,12 @@ method getAll*(db: WakuMessageStore, onData: message_store.DataProc): MessageSto | |||
| ok gotMessages | |||
|
|
|||
| proc adjustDbPageSize(dbPageSize: uint64, matchCount: uint64, returnPageSize: uint64): uint64 {.inline.} = | |||
| var ret = if matchCount < 2: dbPageSize * returnPageSize | |||
| const maxDbPageSize: uint64 = 20000 # the maximum DB page size is limited to prevent excessive use of memory in case of very sparse or non-matching filters. TODO: dynamic, adjust to available memory | |||
There was a problem hiding this comment.
Could you put this constant outside of the function?
There was a problem hiding this comment.
I put it there because it is part of the heuristic of finding the "optimal" page size. In the future, this could change.
Did not want to clutter the outer scope with it. wdyt? No strong opinion here.
Co-authored-by: Lorenzo Delgado <[email protected]>
Co-authored-by: Lorenzo Delgado <[email protected]>
jm-clius
approved these changes
Jun 23, 2022
|
Just as info: Most likely, the dbPageSize will be replaced by putting the filtering into the WHERE clause in the future. |
This was referenced Jun 23, 2022
jakubgs
pushed a commit
to status-im/infra-nim-waku
that referenced
this pull request
Jun 23, 2022
There is a known issue in `v0.10` where certain store queries can slow down nodes: waku-org/nwaku#1017 A possible (partial?) fix has been merged and deployed to `wakuv2.test`: waku-org/nwaku#1018 But the SQLite store can be disable on `prod` in the meantime. Signed-off-by: Jakub Sokołowski <[email protected]>
jakubgs
added a commit
to status-im/infra-nim-waku
that referenced
this pull request
Oct 19, 2022
Otherwise nodes try to load all messages into memory at startup. And the issue that originally caused this to be disabled is closed: waku-org/nwaku#1017 waku-org/nwaku#1018 Signed-off-by: Jakub Sokołowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR limits
dbPageSizeavoiding excessive use of memory in case of sparse or non-matching filters.This PR partly solves #1017