Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: grafana panel for remaining proof per epoch #138

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

darshankabariya
Copy link
Contributor

@darshankabariya darshankabariya commented Nov 26, 2024

This PR is just an update to the dashboard for this PR waku-org/nwaku#3181 and this issue waku-org/nwaku#3024.

Added two panels:

  1. Total Generated Proofs Since Node Start - This value only increases over time.
  2. Remaining Proofs Per Epoch - Displays how many proofs can still be generated until the next epoch; it resets with each new epoch.

image

Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiice! Could you please add a picture of how the new dashboard looks like?

@darshankabariya
Copy link
Contributor Author

Niiice! Could you please add a picture of how the new dashboard looks like?

Included in the description: I generated this Grafana dashboard after running a local node. However, even after running it for over an hour, no RLN data is being displayed.

@gabrielmer
Copy link
Contributor

gabrielmer commented Nov 28, 2024

Included in the description: I generated this Grafana dashboard after running a local node. However, even after running it for over an hour, no RLN data is being displayed.

Maybe it is because you haven't sent messages? Try sending messages from your node, that should generate RLN proofs and we should be able to see the data in the panel

@darshankabariya darshankabariya self-assigned this Nov 29, 2024
@darshankabariya
Copy link
Contributor Author

darshankabariya commented Nov 29, 2024

Included in the description: I generated this Grafana dashboard after running a local node. However, even after running it for over an hour, no RLN data is being displayed.

Maybe it is because you haven't sent messages? Try sending messages from your node, that should generate RLN proofs and we should be able to see the data in the panel

Thanks! I might have missed something. I'll double-check and provide an update.
image

@Ivansete-status
Copy link
Contributor

Thanks for that @darshankabariya !
While running it locally I see the following:
image

  1. What is the difference between "RLN Spam Messages Total" and "RLN Invalid Messages"?
  2. The panel "RLN Invalid Messages Total" seems not needed as I assume is the sum up of all "RLN Invalid Messages".
    Other than that, it looks nice to me 🥳 We'll see how the other two panels look like once deployed in waku fleets, which btw, might need to edit other dashboard file (this dashboard cannot be used there because is a different one.)

@darshankabariya
Copy link
Contributor Author

Thanks for that @darshankabariya ! While running it locally I see the following: image

  1. What is the difference between "RLN Spam Messages Total" and "RLN Invalid Messages"?
  2. The panel "RLN Invalid Messages Total" seems not needed as I assume is the sum up of all "RLN Invalid Messages".
    Other than that, it looks nice to me 🥳 We'll see how the other two panels look like once deployed in waku fleets, which btw, might need to edit other dashboard file (this dashboard cannot be used there because is a different one.)

Actually, I only added the last two panels: 'Total generated RLN proofs' and 'Remaining proofs per epoch.' However, I’m still investigating the logic behind those metrics.

@darshankabariya
Copy link
Contributor Author

darshankabariya commented Dec 3, 2024

Niiice! Could you please add a picture of how the new dashboard looks like?

@gabrielmer @Ivansete-status

@Ivansete-status Ivansete-status changed the title chore: grafana panal for remaining proof per epoch chore: grafana panel for remaining proof per epoch Dec 3, 2024
@Ivansete-status
Copy link
Contributor

@darshankabariya , looking at it more carefully I think we need to adjust the underlying legend (ping me if don't find how to change it.)

And aside from that, I'm curious about why the peak is happening. See below pic for both comments:

image

@darshankabariya
Copy link
Contributor Author

darshankabariya commented Dec 3, 2024

@darshankabariya , looking at it more carefully I think we need to adjust the underlying legend (ping me if don't find how to change it.)

And aside from that, I'm curious about why the peak is happening. See below pic for both comments:

Hi @Ivansete-status As mentioned in the PR description, this is the 'remaining proofs per epoch.' When a new epoch starts, we need to refresh the proof limit. You can see how it works here. However, while explaining the scenario, I found a bug. If a new epoch starts but no messages are sent (i.e., no proofs are generated), the counter doesn’t update because I reset it inside the proof generation function. I’ll fix that bug. Thanks for the suggestion about the underlying legend!

image

You can see that even after a new epoch starts, there's no spike because I didn't send any messages through the chat API.

@darshankabariya darshankabariya merged commit 3b0b06c into master Dec 3, 2024
@darshankabariya darshankabariya deleted the grafana_panal_update branch December 3, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants