Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): sharding: same cluster, different shard #1893

Merged
merged 4 commits into from
Mar 10, 2024

Conversation

danisharora099
Copy link
Collaborator

Problem

The tests written to check connection for nodes when the cluster is same, but the shard is different, was expected to have the nodes connect. This worked fine interop until nwaku rc 0.24.0
With the introduction of the metadata protocol, the tests started to fail since this should not be allowed and the actual expectation from the test is that the nodes should not connect

Solution

Notes

Contribution checklist:

  • covered by unit tests;
  • covered by e2e test;
  • add ! in title if breaks public API;

@danisharora099 danisharora099 marked this pull request as ready for review March 7, 2024 11:48
@danisharora099 danisharora099 requested a review from a team as a code owner March 7, 2024 11:48
Copy link

github-actions bot commented Mar 7, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 185.24 KB (0%) 3.8 s (0%) 1.9 s (+28.14% 🔺) 5.6 s
Waku Simple Light Node 185.17 KB (0%) 3.8 s (0%) 1.9 s (+55.94% 🔺) 5.6 s
ECIES encryption 22.89 KB (0%) 458 ms (0%) 405 ms (+51.21% 🔺) 862 ms
Symmetric encryption 22.34 KB (0%) 447 ms (0%) 292 ms (-52.14% 🔽) 739 ms
DNS discovery 69.95 KB (0%) 1.4 s (0%) 1.2 s (+49.01% 🔺) 2.6 s
Privacy preserving protocols 39.84 KB (0%) 797 ms (0%) 944 ms (+51.27% 🔺) 1.8 s
Light protocols 20.58 KB (0%) 412 ms (0%) 311 ms (+14.4% 🔺) 723 ms
History retrieval protocols 19.34 KB (0%) 387 ms (0%) 361 ms (+45.95% 🔺) 748 ms
Deterministic Message Hashing 4.96 KB (0%) 100 ms (0%) 22 ms (-67.48% 🔽) 121 ms

@danisharora099 danisharora099 merged commit 49c3968 into master Mar 10, 2024
9 of 10 checks passed
@danisharora099 danisharora099 deleted the fix/sharding-tests branch March 10, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: same cluster, different shard: nodes connect tests fail if using a shard different than 0
2 participants