fix(tests): sharding: same cluster, different shard #1893
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The tests written to check connection for nodes when the cluster is same, but the shard is different, was expected to have the nodes connect. This worked fine interop until nwaku rc 0.24.0
With the introduction of the metadata protocol, the tests started to fail since this should not be allowed and the actual expectation from the test is that the nodes should not connect
Solution
Notes
same cluster, different shard: nodes connect
tests fail if using a shard different than 0 #1848Contribution checklist:
!
in title if breaks public API;